Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1263043003: Add NotificationAction.action member (Closed)

Created:
5 years, 4 months ago by johnme
Modified:
5 years, 4 months ago
Reviewers:
Peter Beverloo
CC:
blink-reviews, peter+watch_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@actions
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add NotificationAction.action member This will later be reflected as NotificationEvent.action during notificationclick events from actions, but those aren't yet supported. Depends on https://codereview.chromium.org/1263043002 BUG=513671 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199897

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase + spaces inside { ... } #

Patch Set 3 : Rebase #

Total comments: 4

Patch Set 4 : Review nits #

Patch Set 5 : Rebase #

Patch Set 6 : Fix rebase #

Messages

Total messages: 15 (6 generated)
johnme
5 years, 4 months ago (2015-07-30 15:50:50 UTC) #2
Peter Beverloo
https://codereview.chromium.org/1263043003/diff/1/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html File LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html (right): https://codereview.chromium.org/1263043003/diff/1/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html#newcode37 LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html:37: actions: [{action: "one", title: "Action 1"}, Please be consistent ...
5 years, 4 months ago (2015-07-30 16:25:49 UTC) #3
johnme
Done (and rebased) - thanks! https://codereview.chromium.org/1263043003/diff/1/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html File LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html (right): https://codereview.chromium.org/1263043003/diff/1/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html#newcode37 LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html:37: actions: [{action: "one", title: ...
5 years, 4 months ago (2015-07-31 16:12:19 UTC) #4
Peter Beverloo
lgtm https://codereview.chromium.org/1263043003/diff/40001/LayoutTests/http/tests/notifications/notification-properties.html File LayoutTests/http/tests/notifications/notification-properties.html (right): https://codereview.chromium.org/1263043003/diff/40001/LayoutTests/http/tests/notifications/notification-properties.html#newcode29 LayoutTests/http/tests/notifications/notification-properties.html:29: action: "" + i, No need for "" ...
5 years, 4 months ago (2015-07-31 18:05:34 UTC) #5
johnme
Addressed nits - thanks! https://codereview.chromium.org/1263043003/diff/40001/LayoutTests/http/tests/notifications/notification-properties.html File LayoutTests/http/tests/notifications/notification-properties.html (right): https://codereview.chromium.org/1263043003/diff/40001/LayoutTests/http/tests/notifications/notification-properties.html#newcode29 LayoutTests/http/tests/notifications/notification-properties.html:29: action: "" + i, On ...
5 years, 4 months ago (2015-07-31 18:14:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263043003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263043003/80001
5 years, 4 months ago (2015-08-03 11:22:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/64796)
5 years, 4 months ago (2015-08-03 12:31:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263043003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263043003/100001
5 years, 4 months ago (2015-08-03 13:30:33 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 15:33:55 UTC) #15
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199897

Powered by Google App Engine
This is Rietveld 408576698