Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1275743003: Deliver action clicks to page notifications (chromium) (Closed)

Created:
5 years, 4 months ago by johnme
Modified:
5 years, 2 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-notifications_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, peter+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@click_test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deliver action clicks to page notifications (chromium) WORK IN PROGRESS BUG=513671

Patch Set 1 #

Total comments: 1

Messages

Total messages: 5 (2 generated)
johnme
5 years, 4 months ago (2015-08-07 07:17:16 UTC) #2
Peter Beverloo
https://codereview.chromium.org/1275743003/diff/1/chrome/browser/notifications/notification_object_proxy.cc File chrome/browser/notifications/notification_object_proxy.cc (right): https://codereview.chromium.org/1275743003/diff/1/chrome/browser/notifications/notification_object_proxy.cc#newcode33 chrome/browser/notifications/notification_object_proxy.cc:33: delegate_->NotificationClick(-1); +comment (but preferably a constant, as you suggested ...
5 years, 4 months ago (2015-08-07 07:27:29 UTC) #3
johnme
5 years, 2 months ago (2015-10-20 13:55:55 UTC) #5
Message was sent while issue was closed. 
Abandoned, as the spec now only supports action buttons for persistent (SW)
notifications:
https://github.com/whatwg/notifications/pull/48#issuecomment-148123079

Powered by Google App Engine
This is Rietveld 408576698