Enable testing NotificationEvent.action

components/test_runner/test_runner.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/test_runner/test_runner.h"
 
 #include <limits>
 
 #include "base/logging.h"
 #include "components/test_runner/mock_credential_manager_client.h"
@@ skipping 256 matching lines @@
   void SetDatabaseQuota(int quota);
   void SetAlwaysAcceptCookies(bool accept);
   void SetWindowIsKey(bool value);
   std::string PathToLocalResource(const std::string& path);
   void SetBackingScaleFactor(double value, v8::Local<v8::Function> callback);
   void SetColorProfile(const std::string& name,
                        v8::Local<v8::Function> callback);
   void SetPOSIXLocale(const std::string& locale);
   void SetMIDIAccessorResult(bool result);
   void SimulateWebNotificationClick(const std::string& title);
+  void SimulateWebNotificationActionClick(const std::string& title,

[Peter Beverloo, 2015/08/04 21:08:33]

Can we overload methods here? We shouldn't have two methods for doing
effectively the same thing. If the default bindings don't help you, you can
probably use gin::Arguments* for this.

[johnme, 2015/08/05 13:51:27]

Done, using gin::Arguments*.

+                                          int action_index);
   void AddMockSpeechRecognitionResult(const std::string& transcript,
                                       double confidence);
   void SetMockSpeechRecognitionError(const std::string& error,
                                      const std::string& message);
   bool WasMockSpeechRecognitionAborted();
   void AddMockCredentialManagerResponse(const std::string& id,
                                         const std::string& name,
                                         const std::string& avatar,
                                         const std::string& password);
   void AddWebPageOverlay();
@@ skipping 248 matching lines @@
       .SetMethod("pathToLocalResource",
                  &TestRunnerBindings::PathToLocalResource)
       .SetMethod("setBackingScaleFactor",
                  &TestRunnerBindings::SetBackingScaleFactor)
       .SetMethod("setColorProfile", &TestRunnerBindings::SetColorProfile)
       .SetMethod("setPOSIXLocale", &TestRunnerBindings::SetPOSIXLocale)
       .SetMethod("setMIDIAccessorResult",
                  &TestRunnerBindings::SetMIDIAccessorResult)
       .SetMethod("simulateWebNotificationClick",
                  &TestRunnerBindings::SimulateWebNotificationClick)
+      .SetMethod("simulateWebNotificationActionClick",
+                 &TestRunnerBindings::SimulateWebNotificationActionClick)
       .SetMethod("addMockSpeechRecognitionResult",
                  &TestRunnerBindings::AddMockSpeechRecognitionResult)
       .SetMethod("setMockSpeechRecognitionError",
                  &TestRunnerBindings::SetMockSpeechRecognitionError)
       .SetMethod("wasMockSpeechRecognitionAborted",
                  &TestRunnerBindings::WasMockSpeechRecognitionAborted)
       .SetMethod("addMockCredentialManagerResponse",
                  &TestRunnerBindings::AddMockCredentialManagerResponse)
       .SetMethod("addWebPageOverlay", &TestRunnerBindings::AddWebPageOverlay)
       .SetMethod("removeWebPageOverlay",
@@ skipping 784 matching lines @@
 }
 
 void TestRunnerBindings::SetMIDIAccessorResult(bool result) {
   if (runner_)
     runner_->SetMIDIAccessorResult(result);
 }
 
 void TestRunnerBindings::SimulateWebNotificationClick(
     const std::string& title) {
   if (runner_)
-    runner_->SimulateWebNotificationClick(title);
+    runner_->SimulateWebNotificationClick(title, -1 /* action_index */);
+}
+
+void TestRunnerBindings::SimulateWebNotificationActionClick(
+    const std::string& title, int action_index) {
+  if (runner_)
+    runner_->SimulateWebNotificationClick(title, action_index);
 }
 
 void TestRunnerBindings::AddMockSpeechRecognitionResult(
     const std::string& transcript, double confidence) {
   if (runner_)
     runner_->AddMockSpeechRecognitionResult(transcript, confidence);
 }
 
 void TestRunnerBindings::SetMockSpeechRecognitionError(
     const std::string& error, const std::string& message) {
@@ skipping 1487 matching lines @@
 }
 
 void TestRunner::SetPOSIXLocale(const std::string& locale) {
   delegate_->SetLocale(locale);
 }
 
 void TestRunner::SetMIDIAccessorResult(bool result) {
   midi_accessor_result_ = result;
 }
 
-void TestRunner::SimulateWebNotificationClick(const std::string& title) {
-  delegate_->SimulateWebNotificationClick(title);
+void TestRunner::SimulateWebNotificationClick(const std::string& title,
+                                              int action_index) {
+  delegate_->SimulateWebNotificationClick(title, action_index);
 }
 
 void TestRunner::AddMockSpeechRecognitionResult(const std::string& transcript,
                                                 double confidence) {
   proxy_->GetSpeechRecognizerMock()->AddMockResult(
       WebString::fromUTF8(transcript), confidence);
 }
 
 void TestRunner::SetMockSpeechRecognitionError(const std::string& error,
                                                const std::string& message) {
@@ skipping 192 matching lines @@
 }
 
 void TestRunner::DidLosePointerLockInternal() {
   bool was_locked = pointer_locked_;
   pointer_locked_ = false;
   if (was_locked)
     web_view_->didLosePointerLock();
 }
 
 }  // namespace test_runner