Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1249553002: CSSValue Immediates: Add move operators to CSSPrimitiveValue (Closed)

Created:
5 years, 5 months ago by sashab
Modified:
5 years, 4 months ago
Reviewers:
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_3_tagged_ptrs_with_copy_ops_mv_operators_ref_primvalue
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CSSValue Immediates: Add move operators to CSSPrimitiveValue Add move operators (both constructors and operator= methods) to CSSPrimitiveValue in an attempt to reduce ref-churn. Although this is against the blink style guide, it was done as an experiment to see if performance-related issues were being caused from excessive copy operations. Depends on crrev.com/1246933003. This is part of a larger refactor of CSSValue to introduce immediates, discussed on the bug. BUG=486252 COMMIT=false

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1822 lines, -1618 lines) Patch
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 4 chunks +13 lines, -13 lines 0 comments Download
M Source/core/animation/ColorStyleInterpolation.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ColorStyleInterpolation.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/DeferredLegacyStyleInterpolation.cpp View 1 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/animation/DoubleStyleInterpolationTest.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/animation/ImageSliceStyleInterpolation.cpp View 1 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/animation/KeyframeEffectModelTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolation.cpp View 1 4 chunks +11 lines, -11 lines 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolationTest.cpp View 1 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/animation/LengthPairStyleInterpolation.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/animation/LengthPairStyleInterpolationTest.cpp View 1 2 chunks +16 lines, -16 lines 0 comments Download
M Source/core/animation/LengthStyleInterpolation.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/LengthStyleInterpolation.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/LengthStyleInterpolationTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ListStyleInterpolationTest.cpp View 1 3 chunks +12 lines, -12 lines 0 comments Download
M Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ShadowStyleInterpolation.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ShadowStyleInterpolation.cpp View 1 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/animation/ShadowStyleInterpolationTest.cpp View 1 3 chunks +26 lines, -26 lines 0 comments Download
M Source/core/animation/StringKeyframe.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/animatable/AnimatableUnknown.h View 1 4 chunks +4 lines, -3 lines 0 comments Download
M Source/core/animation/animatable/AnimatableUnknownTest.cpp View 1 1 chunk +15 lines, -15 lines 0 comments Download
M Source/core/css/BasicShapeFunctions.cpp View 1 8 chunks +17 lines, -17 lines 0 comments Download
M Source/core/css/CSSBasicShapes.h View 1 12 chunks +59 lines, -59 lines 0 comments Download
M Source/core/css/CSSBasicShapes.cpp View 1 11 chunks +48 lines, -49 lines 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSCalculationValue.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 1 8 chunks +17 lines, -17 lines 0 comments Download
M Source/core/css/CSSCalculationValueTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSContentDistributionValue.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSGradientValue.h View 1 7 chunks +28 lines, -28 lines 0 comments Download
M Source/core/css/CSSGradientValue.cpp View 1 22 chunks +80 lines, -78 lines 0 comments Download
M Source/core/css/CSSMatrix.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 1 9 chunks +237 lines, -133 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 18 chunks +94 lines, -81 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 194 chunks +216 lines, -216 lines 0 comments Download
M Source/core/css/CSSReflectValue.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/CSSReflectValue.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSShadowValue.h View 1 2 chunks +18 lines, -18 lines 0 comments Download
M Source/core/css/CSSShadowValue.cpp View 1 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/css/CSSValue.h View 1 15 chunks +113 lines, -46 lines 0 comments Download
M Source/core/css/CSSValueObject.cpp View 1 6 chunks +17 lines, -5 lines 0 comments Download
M Source/core/css/CSSValuePool.h View 1 2 chunks +18 lines, -18 lines 0 comments Download
M Source/core/css/CSSValuePool.cpp View 1 2 chunks +17 lines, -17 lines 0 comments Download
M Source/core/css/CSSValueTest.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSValueTestHelper.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 16 chunks +50 lines, -50 lines 0 comments Download
M Source/core/css/Counter.h View 1 2 chunks +14 lines, -14 lines 0 comments Download
M Source/core/css/FontFace.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/Pair.h View 1 3 chunks +11 lines, -11 lines 0 comments Download
M Source/core/css/Rect.h View 1 4 chunks +20 lines, -20 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/StylePropertySet.h View 1 3 chunks +3 lines, -1 line 0 comments Download
M Source/core/css/StylePropertySet.cpp View 1 3 chunks +9 lines, -4 lines 0 comments Download
M Source/core/css/parser/CSSParser.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 1 10 chunks +22 lines, -22 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 109 chunks +224 lines, -223 lines 0 comments Download
M Source/core/css/parser/SizesCalcParserTest.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.cpp View 1 18 chunks +45 lines, -45 lines 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 1 6 chunks +11 lines, -11 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 1 34 chunks +88 lines, -89 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 16 chunks +19 lines, -19 lines 0 comments Download
M Source/core/css/resolver/TransformBuilder.cpp View 1 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.cpp View 1 4 chunks +14 lines, -14 lines 0 comments Download
M Source/core/dom/TextLinkColors.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TextLinkColors.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 29 chunks +59 lines, -59 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/markup.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasFontCache.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/LayoutEditor.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/ReferenceFilterBuilder.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGLength.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLength.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2DState.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PluginPlaceholderImplTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebAXObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1246933003 Patch 40001

Powered by Google App Engine
This is Rietveld 408576698