Source/core/html/canvas/CanvasFontCache.cpp - Issue 1249553002: CSSValue Immediates: Add move operators to CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/CanvasFontCache.cpp

Issue 1249553002: CSSValue Immediates: Add move operators to CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_3_tagged_ptrs_with_copy_ops_mv_operators_ref_primvalue

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/canvas/CanvasFontCache.cpp

diff --git a/Source/core/html/canvas/CanvasFontCache.cpp b/Source/core/html/canvas/CanvasFontCache.cpp

index 99d66a3d143059acd5c9d59b7ffdef13e2994bd7..992df041e5d88c4bd5caa8880172947415f095be 100644

--- a/Source/core/html/canvas/CanvasFontCache.cpp

+++ b/Source/core/html/canvas/CanvasFontCache.cpp

@@ -97,7 +97,7 @@ MutableStylePropertySet* CanvasFontCache::parseFont(const String& fontString)

return nullptr;

// According to http://lists.w3.org/Archives/Public/public-html/2009Jul/0947.html,

// the "inherit" and "initial" values must be ignored.

- NullableCSSValue fontValue = parsedStyle->getPropertyCSSValue(CSSPropertyFontSize);

+ const NullableCSSValue& fontValue = parsedStyle->getPropertyCSSValue(CSSPropertyFontSize);

if (fontValue && (fontValue->isInitialValue() || fontValue->isInheritedValue()))

return nullptr;

m_fetchedFonts.add(fontString, parsedStyle);

« no previous file with comments | « Source/core/html/HTMLElement.cpp ('k') | Source/core/inspector/LayoutEditor.cpp » ('j') | no next file with comments »