Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: Source/core/css/resolver/StyleBuilderConverter.h

Issue 1249553002: CSSValue Immediates: Add move operators to CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_3_tagged_ptrs_with_copy_ops_mv_operators_ref_primvalue
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/resolver/StyleBuilderConverter.h
diff --git a/Source/core/css/resolver/StyleBuilderConverter.h b/Source/core/css/resolver/StyleBuilderConverter.h
index acbcea55a1672f105989a972952aae9daf57c88a..8bbc55cb44189e3ca85a9ee9e6165f2ae3dfb994 100644
--- a/Source/core/css/resolver/StyleBuilderConverter.h
+++ b/Source/core/css/resolver/StyleBuilderConverter.h
@@ -89,11 +89,11 @@ public:
static float convertSpacing(StyleResolverState&, const CSSValue&);
template <CSSValueID IdForNone> static AtomicString convertString(StyleResolverState&, const CSSValue&);
static PassRefPtr<SVGDashArray> convertStrokeDasharray(StyleResolverState&, const CSSValue&);
- static StyleColor convertStyleColor(StyleResolverState&, CSSValue, bool forVisitedLink = false);
+ static StyleColor convertStyleColor(StyleResolverState&, const CSSValue&, bool forVisitedLink = false);
static float convertTextStrokeWidth(StyleResolverState&, const CSSValue&);
static TransformOrigin convertTransformOrigin(StyleResolverState&, const CSSValue&);
- static bool convertGridTrackList(CSSValue, Vector<GridTrackSize>&, NamedGridLinesMap&, OrderedNamedGridLines&, StyleResolverState&);
+ static bool convertGridTrackList(const CSSValue&, Vector<GridTrackSize>&, NamedGridLinesMap&, OrderedNamedGridLines&, StyleResolverState&);
static void createImplicitNamedGridLinesFromGridArea(const NamedGridAreaMap&, NamedGridLinesMap&, GridTrackSizingDirection);
static void convertOrderedNamedGridLinesMapToNamedGridLinesMap(const OrderedNamedGridLines&, NamedGridLinesMap&);
@@ -125,7 +125,7 @@ T StyleBuilderConverter::convertFlags(StyleResolverState& state, const CSSValue&
template <typename T>
T StyleBuilderConverter::convertLineWidth(StyleResolverState& state, const CSSValue& value)
{
- CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
CSSValueID valueID = primitiveValue.getValueID();
if (valueID == CSSValueThin)
return 1;
@@ -151,7 +151,7 @@ T StyleBuilderConverter::convertLineWidth(StyleResolverState& state, const CSSVa
template <CSSValueID IdForNone>
AtomicString StyleBuilderConverter::convertString(StyleResolverState&, const CSSValue& value)
{
- CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
if (primitiveValue.getValueID() == IdForNone)
return nullAtom;
return AtomicString(primitiveValue.getStringValue());
« no previous file with comments | « Source/core/css/resolver/FilterOperationResolver.cpp ('k') | Source/core/css/resolver/StyleBuilderConverter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698