Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/css/resolver/CSSToStyleMap.cpp

Issue 1249553002: CSSValue Immediates: Add move operators to CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_3_tagged_ptrs_with_copy_ops_mv_operators_ref_primvalue
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/parser/SizesCalcParserTest.cpp ('k') | Source/core/css/resolver/FilterOperationResolver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/resolver/CSSToStyleMap.cpp
diff --git a/Source/core/css/resolver/CSSToStyleMap.cpp b/Source/core/css/resolver/CSSToStyleMap.cpp
index 5aa6d2059b9b470ed5df176629c4234d4bb4b5cc..ffd497f42b132d1a718cc96cb367b3590cb4b14b 100644
--- a/Source/core/css/resolver/CSSToStyleMap.cpp
+++ b/Source/core/css/resolver/CSSToStyleMap.cpp
@@ -53,7 +53,7 @@ void CSSToStyleMap::mapFillAttachment(StyleResolverState&, FillLayer* layer, con
if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
switch (primitiveValue.getValueID()) {
case CSSValueFixed:
layer->setAttachment(FixedBackgroundAttachment);
@@ -79,7 +79,7 @@ void CSSToStyleMap::mapFillClip(StyleResolverState&, FillLayer* layer, const CSS
if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
layer->setClip(primitiveValue);
}
@@ -93,7 +93,7 @@ void CSSToStyleMap::mapFillComposite(StyleResolverState&, FillLayer* layer, cons
if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
layer->setComposite(primitiveValue);
}
@@ -107,7 +107,7 @@ void CSSToStyleMap::mapFillBlendMode(StyleResolverState&, FillLayer* layer, cons
if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
layer->setBlendMode(primitiveValue);
}
@@ -121,7 +121,7 @@ void CSSToStyleMap::mapFillOrigin(StyleResolverState&, FillLayer* layer, const C
if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
layer->setOrigin(primitiveValue);
}
@@ -147,7 +147,7 @@ void CSSToStyleMap::mapFillRepeatX(StyleResolverState&, FillLayer* layer, const
if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
layer->setRepeatX(primitiveValue);
}
@@ -161,7 +161,7 @@ void CSSToStyleMap::mapFillRepeatY(StyleResolverState&, FillLayer* layer, const
if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
layer->setRepeatY(primitiveValue);
}
@@ -176,7 +176,7 @@ void CSSToStyleMap::mapFillSize(StyleResolverState& state, FillLayer* layer, con
if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
if (primitiveValue.getValueID() == CSSValueContain)
layer->setSizeType(Contain);
else if (primitiveValue.getValueID() == CSSValueCover)
@@ -195,8 +195,8 @@ void CSSToStyleMap::mapFillSize(StyleResolverState& state, FillLayer* layer, con
Length secondLength;
if (Pair* pair = primitiveValue.getPairValue()) {
- firstLength = StyleBuilderConverter::convertLengthOrAuto(state, CSSValue(*pair->first()));
- secondLength = StyleBuilderConverter::convertLengthOrAuto(state, CSSValue(*pair->second()));
+ firstLength = StyleBuilderConverter::convertLengthOrAuto(state, pair->first());
+ secondLength = StyleBuilderConverter::convertLengthOrAuto(state, pair->second());
} else {
firstLength = StyleBuilderConverter::convertLengthOrAuto(state, value);
secondLength = Length();
@@ -217,16 +217,16 @@ void CSSToStyleMap::mapFillXPosition(StyleResolverState& state, FillLayer* layer
if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue* primitiveValue = &toCSSPrimitiveValue(value);
- Pair* pair = primitiveValue->getPairValue();
+ CSSPrimitiveValue primitiveValue = toCSSPrimitiveValue(value);
+ Pair* pair = primitiveValue.getPairValue();
if (pair)
primitiveValue = pair->second();
- Length length = primitiveValue->convertToLength(state.cssToLengthConversionData());
+ Length length = primitiveValue.convertToLength(state.cssToLengthConversionData());
layer->setXPosition(length);
if (pair)
- layer->setBackgroundXOrigin(*(pair->first()));
+ layer->setBackgroundXOrigin(pair->first());
}
void CSSToStyleMap::mapFillYPosition(StyleResolverState& state, FillLayer* layer, const CSSValue& value)
@@ -239,16 +239,16 @@ void CSSToStyleMap::mapFillYPosition(StyleResolverState& state, FillLayer* layer
if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue* primitiveValue = &toCSSPrimitiveValue(value);
- Pair* pair = primitiveValue->getPairValue();
+ CSSPrimitiveValue primitiveValue = toCSSPrimitiveValue(value);
+ Pair* pair = primitiveValue.getPairValue();
if (pair)
primitiveValue = pair->second();
- Length length = primitiveValue->convertToLength(state.cssToLengthConversionData());
+ Length length = primitiveValue.convertToLength(state.cssToLengthConversionData());
layer->setYPosition(length);
if (pair)
- layer->setBackgroundYOrigin(*(pair->first()));
+ layer->setBackgroundYOrigin(pair->first());
}
void CSSToStyleMap::mapFillMaskSourceType(StyleResolverState&, FillLayer* layer, const CSSValue& value)
@@ -336,7 +336,7 @@ double CSSToStyleMap::mapAnimationIterationCount(const CSSValue& value)
{
if (value.isInitialValue())
return CSSAnimationData::initialIterationCount();
- CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
if (primitiveValue.getValueID() == CSSValueInfinite)
return std::numeric_limits<double>::infinity();
return primitiveValue.getFloatValue();
@@ -346,7 +346,7 @@ AtomicString CSSToStyleMap::mapAnimationName(const CSSValue& value)
{
if (value.isInitialValue())
return CSSAnimationData::initialName();
- CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
if (primitiveValue.getValueID() == CSSValueNone)
return CSSAnimationData::initialName();
return AtomicString(primitiveValue.getStringValue());
@@ -366,7 +366,7 @@ CSSTransitionData::TransitionProperty CSSToStyleMap::mapAnimationProperty(const
{
if (value.isInitialValue())
return CSSTransitionData::initialProperty();
- CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
if (primitiveValue.isCustomIdent())
return CSSTransitionData::TransitionProperty(primitiveValue.getStringValue());
if (primitiveValue.getValueID() == CSSValueAll)
@@ -384,7 +384,7 @@ PassRefPtr<TimingFunction> CSSToStyleMap::mapAnimationTimingFunction(const CSSVa
// properties in shorthands to initial.
if (value.isPrimitiveValue()) {
- CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
switch (primitiveValue.getValueID()) {
case CSSValueLinear:
return LinearTimingFunction::shared();
@@ -495,29 +495,29 @@ void CSSToStyleMap::mapNinePieceImageSlice(StyleResolverState&, const NullableCS
// Set up a length box to represent our image slices.
LengthBox box;
Quad* slices = borderImageSlice->slices();
- if (slices->top()->isPercentage())
- box.m_top = Length(slices->top()->getDoubleValue(), Percent);
+ if (slices->top().isPercentage())
+ box.m_top = Length(slices->top().getDoubleValue(), Percent);
else
- box.m_top = Length(slices->top()->getIntValue(), Fixed);
- if (slices->bottom()->isPercentage())
- box.m_bottom = Length(slices->bottom()->getDoubleValue(), Percent);
+ box.m_top = Length(slices->top().getIntValue(), Fixed);
+ if (slices->bottom().isPercentage())
+ box.m_bottom = Length(slices->bottom().getDoubleValue(), Percent);
else
- box.m_bottom = Length(slices->bottom()->getIntValue(), Fixed);
- if (slices->left()->isPercentage())
- box.m_left = Length(slices->left()->getDoubleValue(), Percent);
+ box.m_bottom = Length(slices->bottom().getIntValue(), Fixed);
+ if (slices->left().isPercentage())
+ box.m_left = Length(slices->left().getDoubleValue(), Percent);
else
- box.m_left = Length(slices->left()->getIntValue(), Fixed);
- if (slices->right()->isPercentage())
- box.m_right = Length(slices->right()->getDoubleValue(), Percent);
+ box.m_left = Length(slices->left().getIntValue(), Fixed);
+ if (slices->right().isPercentage())
+ box.m_right = Length(slices->right().getDoubleValue(), Percent);
else
- box.m_right = Length(slices->right()->getIntValue(), Fixed);
+ box.m_right = Length(slices->right().getIntValue(), Fixed);
image.setImageSlices(box);
// Set our fill mode.
image.setFill(borderImageSlice->m_fill);
}
-static BorderImageLength toBorderImageLength(CSSPrimitiveValue& value, const CSSToLengthConversionData& conversionData)
+static BorderImageLength toBorderImageLength(CSSPrimitiveValue value, const CSSToLengthConversionData& conversionData)
{
if (value.isNumber())
return value.getDoubleValue();
@@ -533,14 +533,14 @@ BorderImageLengthBox CSSToStyleMap::mapNinePieceImageQuad(StyleResolverState& st
if (!value || !value->isPrimitiveValue())
return BorderImageLengthBox(Length(Auto));
- Quad* slices = toCSSPrimitiveValue(value)->getQuadValue();
+ Quad* slices = toCSSPrimitiveValue(value).getQuadValue();
// Set up a border image length box to represent our image slices.
return BorderImageLengthBox(
- toBorderImageLength(*slices->top(), state.cssToLengthConversionData()),
- toBorderImageLength(*slices->right(), state.cssToLengthConversionData()),
- toBorderImageLength(*slices->bottom(), state.cssToLengthConversionData()),
- toBorderImageLength(*slices->left(), state.cssToLengthConversionData()));
+ toBorderImageLength(slices->top(), state.cssToLengthConversionData()),
+ toBorderImageLength(slices->right(), state.cssToLengthConversionData()),
+ toBorderImageLength(slices->bottom(), state.cssToLengthConversionData()),
+ toBorderImageLength(slices->left(), state.cssToLengthConversionData()));
}
void CSSToStyleMap::mapNinePieceImageRepeat(StyleResolverState&, const NullableCSSValue& value, NinePieceImage& image)
@@ -548,13 +548,13 @@ void CSSToStyleMap::mapNinePieceImageRepeat(StyleResolverState&, const NullableC
if (!value || !value->isPrimitiveValue())
return;
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- Pair* pair = primitiveValue->getPairValue();
- if (!pair || !pair->first() || !pair->second())
+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ Pair* pair = primitiveValue.getPairValue();
+ if (!pair)
return;
- CSSValueID firstIdentifier = pair->first()->getValueID();
- CSSValueID secondIdentifier = pair->second()->getValueID();
+ CSSValueID firstIdentifier = pair->first().getValueID();
+ CSSValueID secondIdentifier = pair->second().getValueID();
ENinePieceImageRule horizontalRule;
switch (firstIdentifier) {
« no previous file with comments | « Source/core/css/parser/SizesCalcParserTest.cpp ('k') | Source/core/css/resolver/FilterOperationResolver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698