Source/core/css/parser/SizesCalcParserTest.cpp - Issue 1249553002: CSSValue Immediates: Add move operators to CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/SizesCalcParserTest.cpp

Issue 1249553002: CSSValue Immediates: Add move operators to CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_3_tagged_ptrs_with_copy_ops_mv_operators_ref_primvalue

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/parser/SizesCalcParserTest.cpp

diff --git a/Source/core/css/parser/SizesCalcParserTest.cpp b/Source/core/css/parser/SizesCalcParserTest.cpp

index b1edc32076b1e26d8347bff71bffd663ecfd34e1..074565d3831a3204abac955c294e19625a8c33fb 100644

--- a/Source/core/css/parser/SizesCalcParserTest.cpp

+++ b/Source/core/css/parser/SizesCalcParserTest.cpp

@@ -34,9 +34,8 @@ static void verifyCSSCalc(String text, double value, bool valid, unsigned fontSi

CSSLengthArray lengthArray;

initLengthArray(lengthArray);

NullableCSSValue cssValue = CSSParser::parseSingleValue(CSSPropertyLeft, text);

- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(cssValue);

- if (primitiveValue)

- primitiveValue->accumulateLengthArray(lengthArray);

+ if (cssValue)

+ toCSSPrimitiveValue(cssValue).accumulateLengthArray(lengthArray);

else

ASSERT_EQ(valid, false);

float length = lengthArray.at(CSSPrimitiveValue::UnitTypePixels);

« no previous file with comments | « Source/core/css/parser/CSSPropertyParser.cpp ('k') | Source/core/css/resolver/CSSToStyleMap.cpp » ('j') | no next file with comments »