Source/core/css/ComputedStyleCSSValueMapping.h - Issue 1249553002: CSSValue Immediates: Add move operators to CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/ComputedStyleCSSValueMapping.h

Issue 1249553002: CSSValue Immediates: Add move operators to CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_3_tagged_ptrs_with_copy_ops_mv_operators_ref_primvalue

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/ComputedStyleCSSValueMapping.h

diff --git a/Source/core/css/ComputedStyleCSSValueMapping.h b/Source/core/css/ComputedStyleCSSValueMapping.h

index 5c392a46dddb513b62122445f55a37e5ee711a16..50b14ec482b9202f0baffc8276968ec945395144 100644

--- a/Source/core/css/ComputedStyleCSSValueMapping.h

+++ b/Source/core/css/ComputedStyleCSSValueMapping.h

@@ -23,7 +23,7 @@ public:

// FIXME: Resolve computed auto alignment in applyProperty/ComputedStyle and remove this non-const styledNode parameter.

static NullableCSSValue get(CSSPropertyID, const ComputedStyle&, const LayoutObject* = nullptr, Node* styledNode = nullptr, bool allowVisitedStyle = false);

private:

- static PassRefPtrWillBeRawPtr<CSSPrimitiveValue> currentColorOrValidColor(const ComputedStyle&, const StyleColor&);

+ static CSSPrimitiveValue currentColorOrValidColor(const ComputedStyle&, const StyleColor&);

static CSSValue valueForShadowData(const ShadowData&, const ComputedStyle&, bool useSpread);

static CSSValue valueForShadowList(const ShadowList*, const ComputedStyle&, bool useSpread);

static CSSValue valueForFilter(const ComputedStyle&);

« no previous file with comments | « Source/core/css/CSSValueTestHelper.h ('k') | Source/core/css/ComputedStyleCSSValueMapping.cpp » ('j') | no next file with comments »