Source/core/animation/StringKeyframe.h - Issue 1249553002: CSSValue Immediates: Add move operators to CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/StringKeyframe.h

Issue 1249553002: CSSValue Immediates: Add move operators to CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_3_tagged_ptrs_with_copy_ops_mv_operators_ref_primvalue

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/ShadowStyleInterpolationTest.cpp ('k') | Source/core/animation/animatable/AnimatableUnknown.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/StringKeyframe.h

diff --git a/Source/core/animation/StringKeyframe.h b/Source/core/animation/StringKeyframe.h

index 95b5dc142c5af278d88d42e1adc4ac77124516b1..14a4df5f966d84e3fde1b9c490477d65bb60049d 100644

--- a/Source/core/animation/StringKeyframe.h

+++ b/Source/core/animation/StringKeyframe.h

@@ -60,9 +60,9 @@ public:

virtual PassOwnPtrWillBeRawPtr<Keyframe::PropertySpecificKeyframe> cloneWithOffset(double offset) const;

virtual bool isCSSPropertySpecificKeyframe() const override { return true; }

- static bool createInterpolationsFromCSSValues(CSSPropertyID, CSSValue fromCSSValue, CSSValue toCSSValue, Element*, OwnPtrWillBeRawPtr<WillBeHeapVector<RefPtrWillBeMember<Interpolation>>>& interpolations);

+ static bool createInterpolationsFromCSSValues(CSSPropertyID, const CSSValue& fromCSSValue, const CSSValue& toCSSValue, Element*, OwnPtrWillBeRawPtr<WillBeHeapVector<RefPtrWillBeMember<Interpolation>>>& interpolations);

- void populateAnimatableValueCaches(CSSPropertyID, Keyframe::PropertySpecificKeyframe&, Element*, CSSValue& fromCSSValue, CSSValue& toCSSValue) const;

+ void populateAnimatableValueCaches(CSSPropertyID, Keyframe::PropertySpecificKeyframe&, Element*, const CSSValue& fromCSSValue, const CSSValue& toCSSValue) const;

NullableCSSValue m_value;

mutable RefPtrWillBeMember<AnimatableValue> m_animatableValueCache;

« no previous file with comments | « Source/core/animation/ShadowStyleInterpolationTest.cpp ('k') | Source/core/animation/animatable/AnimatableUnknown.h » ('j') | no next file with comments »