Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1246933003: CSSValue patch 1 with const CSSValue& and move operators (Closed)

Created:
5 years, 5 months ago by sashab
Modified:
5 years, 4 months ago
Reviewers:
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_1_without_copy_ops
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CSSValue Immediates: Add move operators to CSSValue and NullableCSSValue Add move operators (both constructors and operator= methods) to CSSValue and NullableCSSValue in an attempt to reduce ref-churn. Although this is against the blink style guide, it was done as an experiment to see if performance-related issues were being caused from excessive copy operations. Depends on crrev.com/1238943004. This is part of a larger refactor of CSSValue to introduce immediates, discussed on the bug. BUG=486252 COMMIT=false

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M Source/core/css/CSSValue.h View 4 chunks +32 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Powered by Google App Engine
This is Rietveld 408576698