Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1238943004: CSSValue Immediates: Replace CSSValue usage with const references (Closed)

Created:
5 years, 5 months ago by sashab
Modified:
5 years, 4 months ago
Reviewers:
CC:
blink-reviews, shans, arv+blink, blink-reviews-style_chromium.org, vivekg_samsung, blink-reviews-animation_chromium.org, blink-reviews-css, dshwang, Justin Novosad, vivekg, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, darktears, rjwright, apavlov+blink_chromium.org, rwlbuis, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CSSValue Immediates: Replace CSSValue usage with const references Replaced all instances of CSSValue and NullableCSSValue with const CSSValue& and const NullableCSSValue&, respectively, where possible. This is an attempt to reduce ref-churn instroduced by CSSValue. Depends on crrev.com/1164573002. This is part of a larger refactor of CSSValue to introduce immediates, discussed on the bug. BUG=486252

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -281 lines) Patch
M Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/StyleBuilder.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 4 chunks +8 lines, -7 lines 0 comments Download
M Source/build/scripts/templates/StyleBuilderFunctions.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CSSValueInterpolationType.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/CSSValueInterpolationType.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/animation/ConstantStyleInterpolation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/DoubleStyleInterpolationTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/ImageStyleInterpolation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ListStyleInterpolationTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/animatable/AnimatableImage.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/animatable/AnimatableImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/animatable/AnimatableUnknown.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCrossfadeValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSCursorImageValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCursorImageValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSProperty.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValueList.h View 1 chunk +5 lines, -6 lines 0 comments Download
M Source/core/css/CSSValueList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySerializer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/StylePropertySet.h View 5 chunks +5 lines, -7 lines 0 comments Download
M Source/core/css/StylePropertySet.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.h View 1 chunk +25 lines, -25 lines 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.cpp View 24 chunks +26 lines, -26 lines 0 comments Download
M Source/core/css/resolver/ElementStyleResources.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ElementStyleResources.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/resolver/StyleBuilder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.h View 3 chunks +52 lines, -52 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 40 chunks +44 lines, -44 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 25 chunks +30 lines, -30 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/TransformBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/TransformBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/page/PageSerializer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageSerializer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2DState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2DState.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1164573002 Patch 770001

Dependent Patchsets:

Issue 1246933003 Patch 40001

Powered by Google App Engine
This is Rietveld 408576698