Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: Source/core/css/resolver/TransformBuilder.cpp

Issue 1238943004: CSSValue Immediates: Replace CSSValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_1
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/resolver/TransformBuilder.h ('k') | Source/core/editing/EditingStyle.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 case CSSValueMatrix: return TransformOperation::Matrix; 72 case CSSValueMatrix: return TransformOperation::Matrix;
73 case CSSValueMatrix3d: return TransformOperation::Matrix3D; 73 case CSSValueMatrix3d: return TransformOperation::Matrix3D;
74 case CSSValuePerspective: return TransformOperation::Perspective; 74 case CSSValuePerspective: return TransformOperation::Perspective;
75 default: 75 default:
76 ASSERT_NOT_REACHED(); 76 ASSERT_NOT_REACHED();
77 // FIXME: We shouldn't have a type None since we never create them 77 // FIXME: We shouldn't have a type None since we never create them
78 return TransformOperation::None; 78 return TransformOperation::None;
79 } 79 }
80 } 80 }
81 81
82 void TransformBuilder::createTransformOperations(CSSValue& inValue, const CSSToL engthConversionData& conversionData, TransformOperations& outOperations) 82 void TransformBuilder::createTransformOperations(const CSSValue& inValue, const CSSToLengthConversionData& conversionData, TransformOperations& outOperations)
83 { 83 {
84 ASSERT(!outOperations.size()); 84 ASSERT(!outOperations.size());
85 if (!inValue.isValueList()) { 85 if (!inValue.isValueList()) {
86 ASSERT(inValue.isPrimitiveValue() && toCSSPrimitiveValue(inValue).getVal ueID() == CSSValueNone); 86 ASSERT(inValue.isPrimitiveValue() && toCSSPrimitiveValue(inValue).getVal ueID() == CSSValueNone);
87 return; 87 return;
88 } 88 }
89 89
90 float zoomFactor = conversionData.zoom(); 90 float zoomFactor = conversionData.zoom();
91 for (auto& value : toCSSValueList(inValue)) { 91 for (auto& value : toCSSValueList(inValue)) {
92 CSSFunctionValue& transformValue = toCSSFunctionValue(value); 92 CSSFunctionValue& transformValue = toCSSFunctionValue(value);
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 break; 245 break;
246 } 246 }
247 default: 247 default:
248 ASSERT_NOT_REACHED(); 248 ASSERT_NOT_REACHED();
249 break; 249 break;
250 } 250 }
251 } 251 }
252 } 252 }
253 253
254 } // namespace blink 254 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/css/resolver/TransformBuilder.h ('k') | Source/core/editing/EditingStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698