Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: Source/core/animation/DoubleStyleInterpolationTest.cpp

Issue 1238943004: CSSValue Immediates: Replace CSSValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_1
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/ConstantStyleInterpolation.h ('k') | Source/core/animation/ImageStyleInterpolation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/DoubleStyleInterpolationTest.cpp
diff --git a/Source/core/animation/DoubleStyleInterpolationTest.cpp b/Source/core/animation/DoubleStyleInterpolationTest.cpp
index 7eba8236a4487fd1de6e539a3eede65e9a1741f6..5dfe0b1f37656631c24e936b10290f1316dd2391 100644
--- a/Source/core/animation/DoubleStyleInterpolationTest.cpp
+++ b/Source/core/animation/DoubleStyleInterpolationTest.cpp
@@ -81,7 +81,7 @@ protected:
TEST_F(AnimationDoubleStyleInterpolationTest, ZeroValue)
{
- CSSValue value = roundTrip(CSSPrimitiveValue::create(0, CSSPrimitiveValue::CSS_NUMBER));
+ const CSSValue& value = roundTrip(CSSPrimitiveValue::create(0, CSSPrimitiveValue::CSS_NUMBER));
testPrimitiveValue(value, 0, CSSPrimitiveValue::CSS_NUMBER);
}
@@ -114,7 +114,7 @@ TEST_F(AnimationDoubleStyleInterpolationTest, ZeroValueFixedMotionRotation)
{
RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
list->append(CSSPrimitiveValue::create(0, CSSPrimitiveValue::CSS_DEG));
- CSSValue value = roundTripMotionRotation(list.release(), false);
+ const CSSValue& value = roundTripMotionRotation(list.release(), false);
testValueListMotionRotation(value, 0, false);
}
@@ -123,7 +123,7 @@ TEST_F(AnimationDoubleStyleInterpolationTest, ZeroValueAutoMotionRotation)
RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
list->append(CSSPrimitiveValue::createIdentifier(CSSValueAuto));
list->append(CSSPrimitiveValue::create(0, CSSPrimitiveValue::CSS_DEG));
- CSSValue value = roundTripMotionRotation(list.release(), true);
+ const CSSValue& value = roundTripMotionRotation(list.release(), true);
testValueListMotionRotation(value, 0, true);
}
@@ -131,7 +131,7 @@ TEST_F(AnimationDoubleStyleInterpolationTest, ValueFixedMotionRotation)
{
RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
list->append(CSSPrimitiveValue::create(90, CSSPrimitiveValue::CSS_DEG));
- CSSValue value = roundTripMotionRotation(list.release(), false);
+ const CSSValue& value = roundTripMotionRotation(list.release(), false);
testValueListMotionRotation(value, 90, false);
}
@@ -140,7 +140,7 @@ TEST_F(AnimationDoubleStyleInterpolationTest, ValueAutoMotionRotation)
RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
list->append(CSSPrimitiveValue::createIdentifier(CSSValueAuto));
list->append(CSSPrimitiveValue::create(90, CSSPrimitiveValue::CSS_DEG));
- CSSValue value = roundTripMotionRotation(list.release(), true);
+ const CSSValue& value = roundTripMotionRotation(list.release(), true);
testValueListMotionRotation(value, 90, true);
}
« no previous file with comments | « Source/core/animation/ConstantStyleInterpolation.h ('k') | Source/core/animation/ImageStyleInterpolation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698