Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: Source/core/css/resolver/FilterOperationResolver.cpp

Issue 1238943004: CSSValue Immediates: Replace CSSValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_1
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/resolver/FilterOperationResolver.h ('k') | Source/core/css/resolver/StyleBuilder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/resolver/FilterOperationResolver.cpp
diff --git a/Source/core/css/resolver/FilterOperationResolver.cpp b/Source/core/css/resolver/FilterOperationResolver.cpp
index 348c7a09854c42c3501c04de589a8248fd2c2d48..adccab71e3ba223cfd04a244b2daeb01221938e9 100644
--- a/Source/core/css/resolver/FilterOperationResolver.cpp
+++ b/Source/core/css/resolver/FilterOperationResolver.cpp
@@ -71,7 +71,7 @@ static FilterOperation::OperationType filterOperationForType(CSSValueID type)
}
}
-bool FilterOperationResolver::createFilterOperations(CSSValue inValue, const CSSToLengthConversionData& conversionData, FilterOperations& outOperations, StyleResolverState& state)
+bool FilterOperationResolver::createFilterOperations(const CSSValue& inValue, const CSSToLengthConversionData& conversionData, FilterOperations& outOperations, StyleResolverState& state)
{
ASSERT(outOperations.isEmpty());
@@ -92,7 +92,7 @@ bool FilterOperationResolver::createFilterOperations(CSSValue inValue, const CSS
if (operationType == FilterOperation::REFERENCE) {
if (filterValue.length() != 1)
continue;
- CSSValue argument = filterValue.item(0);
+ const CSSValue& argument = filterValue.item(0);
if (!argument.isSVGDocumentValue())
continue;
@@ -173,7 +173,7 @@ bool FilterOperationResolver::createFilterOperations(CSSValue inValue, const CSS
if (filterValue.length() != 1)
return false;
- CSSValue cssValue = filterValue.item(0);
+ const CSSValue& cssValue = filterValue.item(0);
if (!cssValue.isShadowValue())
continue;
« no previous file with comments | « Source/core/css/resolver/FilterOperationResolver.h ('k') | Source/core/css/resolver/StyleBuilder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698