Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: Source/core/css/CSSValueList.cpp

Issue 1238943004: CSSValue Immediates: Replace CSSValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_1
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSValueList.h ('k') | Source/core/css/PropertySetCSSStyleDeclaration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSValueList.cpp
diff --git a/Source/core/css/CSSValueList.cpp b/Source/core/css/CSSValueList.cpp
index cd59514bf950642a323a3d95c17e912aba433dd6..9ff9d8741b0f3a92ffe5554e204cc99bfed087f5 100644
--- a/Source/core/css/CSSValueList.cpp
+++ b/Source/core/css/CSSValueList.cpp
@@ -38,7 +38,7 @@ CSSValueList::CSSValueList(ValueListSeparator listSeparator)
m_valueListSeparator = listSeparator;
}
-bool CSSValueList::removeAll(CSSValue val)
+bool CSSValueList::removeAll(const CSSValue& val)
{
bool found = false;
for (int index = m_values.size() - 1; index >= 0; --index) {
@@ -52,7 +52,7 @@ bool CSSValueList::removeAll(CSSValue val)
return found;
}
-bool CSSValueList::hasValue(CSSValue val) const
+bool CSSValueList::hasValue(const CSSValue& val) const
{
for (size_t index = 0; index < m_values.size(); index++) {
const CSSValue& value = m_values.at(index);
« no previous file with comments | « Source/core/css/CSSValueList.h ('k') | Source/core/css/PropertySetCSSStyleDeclaration.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698