Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1632)

Side by Side Diff: Source/core/animation/ListStyleInterpolationTest.cpp

Issue 1238943004: CSSValue Immediates: Replace CSSValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_1
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/animation/ListStyleInterpolation.h" 6 #include "core/animation/ListStyleInterpolation.h"
7 7
8 #include "core/animation/LengthStyleInterpolation.h" 8 #include "core/animation/LengthStyleInterpolation.h"
9 #include "core/animation/ShadowStyleInterpolation.h" 9 #include "core/animation/ShadowStyleInterpolation.h"
10 10
11 #include <gtest/gtest.h> 11 #include <gtest/gtest.h>
12 12
13 namespace blink { 13 namespace blink {
14 14
15 class ListStyleInterpolationTest : public ::testing::Test { 15 class ListStyleInterpolationTest : public ::testing::Test {
16 16
17 protected: 17 protected:
18 static CSSValue lengthRoundTrip(CSSValue value, InterpolationRange range) 18 static CSSValue lengthRoundTrip(CSSValue value, InterpolationRange range)
19 { 19 {
20 return ListStyleInterpolationImpl<LengthStyleInterpolation, void>::inter polableValueToList( 20 return ListStyleInterpolationImpl<LengthStyleInterpolation, void>::inter polableValueToList(
21 ListStyleInterpolationImpl<LengthStyleInterpolation, void>::listToIn terpolableValue(toCSSValueList(value)).get(), range); 21 ListStyleInterpolationImpl<LengthStyleInterpolation, void>::listToIn terpolableValue(toCSSValueList(value)).get(), range);
22 } 22 }
23 23
24 static void compareLengthLists(PassRefPtrWillBeRawPtr<CSSValueList> expected List, CSSValue actualList) 24 static void compareLengthLists(PassRefPtrWillBeRawPtr<CSSValueList> expected List, CSSValue actualList)
25 { 25 {
26 ASSERT(actualList.isValueList()); 26 ASSERT(actualList.isValueList());
27 27
28 for (size_t i = 0; i < 10; i++) { 28 for (size_t i = 0; i < 10; i++) {
29 CSSValue currentExpectedValue = expectedList->item(i); 29 const CSSValue& currentExpectedValue = expectedList->item(i);
30 CSSValue currentActualValue = toCSSValueList(actualList).item(i); 30 const CSSValue& currentActualValue = toCSSValueList(actualList).item (i);
31 ASSERT(currentExpectedValue.isPrimitiveValue()); 31 ASSERT(currentExpectedValue.isPrimitiveValue());
32 ASSERT(currentActualValue.isPrimitiveValue()); 32 ASSERT(currentActualValue.isPrimitiveValue());
33 33
34 EXPECT_EQ(toCSSPrimitiveValue(currentExpectedValue).getDoubleValue() , toCSSPrimitiveValue(currentActualValue).getDoubleValue()); 34 EXPECT_EQ(toCSSPrimitiveValue(currentExpectedValue).getDoubleValue() , toCSSPrimitiveValue(currentActualValue).getDoubleValue());
35 EXPECT_EQ(toCSSPrimitiveValue(currentExpectedValue).getDoubleValue() , toCSSPrimitiveValue(currentActualValue).getDoubleValue()); 35 EXPECT_EQ(toCSSPrimitiveValue(currentExpectedValue).getDoubleValue() , toCSSPrimitiveValue(currentActualValue).getDoubleValue());
36 } 36 }
37 } 37 }
38 38
39 static CSSValue shadowRoundTrip(CSSValue value) 39 static CSSValue shadowRoundTrip(CSSValue value)
40 { 40 {
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 RefPtrWillBeRawPtr<CSSValueList> expectedList = CSSValueList::createCommaSep arated(); 91 RefPtrWillBeRawPtr<CSSValueList> expectedList = CSSValueList::createCommaSep arated();
92 RefPtrWillBeRawPtr<CSSShadowValue> shadowValue = createShadowValue(); 92 RefPtrWillBeRawPtr<CSSShadowValue> shadowValue = createShadowValue();
93 for (size_t i = 0; i < 10; i++) { 93 for (size_t i = 0; i < 10; i++) {
94 expectedList->append(shadowValue); 94 expectedList->append(shadowValue);
95 } 95 }
96 96
97 compareShadowList(expectedList, shadowRoundTrip(expectedList)); 97 compareShadowList(expectedList, shadowRoundTrip(expectedList));
98 } 98 }
99 99
100 } // namespace blink 100 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/animation/LengthBoxStyleInterpolation.cpp ('k') | Source/core/animation/animatable/AnimatableImage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698