Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: Source/core/css/CSSValueList.h

Issue 1238943004: CSSValue Immediates: Replace CSSValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_1
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSStyleDeclaration.h ('k') | Source/core/css/CSSValueList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSValueList.h
diff --git a/Source/core/css/CSSValueList.h b/Source/core/css/CSSValueList.h
index 12d0e62c2d1e7d4c0006241f74645fc9f8422b33..9198df217207628c045c51c77e964741e593be26 100644
--- a/Source/core/css/CSSValueList.h
+++ b/Source/core/css/CSSValueList.h
@@ -52,15 +52,14 @@ public:
const_iterator end() const { return m_values.end(); }
size_t length() const { return m_values.size(); }
- CSSValue item(size_t index) { return m_values[index]; }
- const CSSValue item(size_t index) const { return m_values[index]; }
+ const CSSValue& item(size_t index) const { return m_values[index]; }
NullableCSSValue itemWithBoundsCheck(size_t index) { return index < m_values.size() ? NullableCSSValue(m_values[index]) : nullptr; }
const NullableCSSValue itemWithBoundsCheck(size_t index) const { return index < m_values.size() ? NullableCSSValue(m_values[index]) : nullptr; }
- void append(CSSValue value) { m_values.append(value); }
- void prepend(CSSValue value) { m_values.prepend(value); }
- bool removeAll(CSSValue);
- bool hasValue(CSSValue) const;
+ void append(const CSSValue& value) { m_values.append(value); }
+ void prepend(const CSSValue& value) { m_values.prepend(value); }
+ bool removeAll(const CSSValue&);
+ bool hasValue(const CSSValue&) const;
PassRefPtrWillBeRawPtr<CSSValueList> copy();
String customCSSText() const;
« no previous file with comments | « Source/core/css/CSSStyleDeclaration.h ('k') | Source/core/css/CSSValueList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698