Move SmartPointer to base.

Move SmartPointer to base.

Committed: https://crrev.com/d02f62484e4aad10142543a41b45549d25c207e1
Cr-Commit-Position: refs/heads/master@{#29604}

[rmcilroy, 2015-07-08 14:30:58]

rmcilroy@chromium.org changed reviewers:
+ jochen@chromium.org

[rmcilroy, 2015-07-08 14:30:58]

PTAL, thanks.

https://codereview.chromium.org/1221433021/diff/1/src/base/smart-pointers.h
File src/base/smart-pointers.h (right):

https://codereview.chromium.org/1221433021/diff/1/src/base/smart-pointers.h#n...
src/base/smart-pointers.h:90: namespace internal {
I kept this in namespace v8::internal to avoid ugly namespaces every where it is
used (much like smart_ptr isn't in namespace base::).

https://codereview.chromium.org/1221433021/diff/1/test/unittests/test-utils.cc
File test/unittests/test-utils.cc (right):

https://codereview.chromium.org/1221433021/diff/1/test/unittests/test-utils.c...
test/unittests/test-utils.cc:78: :
rng_(GetRandomSeedFromFlag(::v8::internal::FLAG_random_seed)) {}
Not sure why this change ended up being necessary, but I get a compile error
here after moving SmartPointer otherwise.

[jochen (gone - plz use gerrit), 2015-07-10 08:35:38]

https://codereview.chromium.org/1221433021/diff/1/src/base/smart-pointers.h
File src/base/smart-pointers.h (right):

https://codereview.chromium.org/1221433021/diff/1/src/base/smart-pointers.h#n...
src/base/smart-pointers.h:90: namespace internal {
On 2015/07/08 at 14:30:58, rmcilroy wrote:
> I kept this in namespace v8::internal to avoid ugly namespaces every where it
is used (much like smart_ptr isn't in namespace base::).

hum, i'd rather have it in base. scoped_ptr isn't e.g. in namespace content
either.

[rmcilroy, 2015-07-10 14:45:24]

On 2015/07/10 08:35:38, jochen wrote:
> https://codereview.chromium.org/1221433021/diff/1/src/base/smart-pointers.h
> File src/base/smart-pointers.h (right):
> 
>
https://codereview.chromium.org/1221433021/diff/1/src/base/smart-pointers.h#n...
> src/base/smart-pointers.h:90: namespace internal {
> On 2015/07/08 at 14:30:58, rmcilroy wrote:
> > I kept this in namespace v8::internal to avoid ugly namespaces every where
it
> is used (much like smart_ptr isn't in namespace base::).
> 
> hum, i'd rather have it in base. scoped_ptr isn't e.g. in namespace content
> either.

Ok, done. PTAL, thanks.

[rmcilroy, 2015-07-10 15:56:56]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-10 15:57:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1221433021/50001

[commit-bot: I haz the power, 2015-07-10 16:24:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-10 16:25:00]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2015-07-13 08:56:04]

lgtm

[rmcilroy, 2015-07-13 11:29:01]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2015-07-13 11:29:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1221433021/50001

[commit-bot: I haz the power, 2015-07-13 12:38:13]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2015-07-13 12:38:27]

Patchset 4 (id:??) landed as
https://crrev.com/d02f62484e4aad10142543a41b45549d25c207e1
Cr-Commit-Position: refs/heads/master@{#29604}

[Michael Achenbach, 2015-07-14 08:35:34]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2015-07-14 08:35:35]

https://codereview.chromium.org/1221433021/diff/50001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1221433021/diff/50001/BUILD.gn#newcode1479
BUILD.gn:1479: "src/hase/smart-pointers.h",
s/hase/base

I'll upload a patch and back-merge to the roll.

[rmcilroy, 2015-07-14 09:37:29]

https://codereview.chromium.org/1221433021/diff/50001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1221433021/diff/50001/BUILD.gn#newcode1479
BUILD.gn:1479: "src/hase/smart-pointers.h",
On 2015/07/14 08:35:35, Michael Achenbach wrote:
> s/hase/base
> 
> I'll upload a patch and back-merge to the roll.

oops! Sorry, thanks!

p.s. Do we not have a GN bot on the V8 waterfall / CQ?