Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: src/strings-storage.cc

Issue 1221433021: Move SmartPointer to base. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove some unecessary header includes Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/strings-storage.h" 7 #include "src/strings-storage.h"
8 8
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 } 73 }
74 return AddOrDisposeString(str.start(), len); 74 return AddOrDisposeString(str.start(), len);
75 } 75 }
76 76
77 77
78 const char* StringsStorage::GetName(Name* name) { 78 const char* StringsStorage::GetName(Name* name) {
79 if (name->IsString()) { 79 if (name->IsString()) {
80 String* str = String::cast(name); 80 String* str = String::cast(name);
81 int length = Min(kMaxNameSize, str->length()); 81 int length = Min(kMaxNameSize, str->length());
82 int actual_length = 0; 82 int actual_length = 0;
83 SmartArrayPointer<char> data = str->ToCString( 83 base::SmartArrayPointer<char> data = str->ToCString(
84 DISALLOW_NULLS, ROBUST_STRING_TRAVERSAL, 0, length, &actual_length); 84 DISALLOW_NULLS, ROBUST_STRING_TRAVERSAL, 0, length, &actual_length);
85 return AddOrDisposeString(data.Detach(), actual_length); 85 return AddOrDisposeString(data.Detach(), actual_length);
86 } else if (name->IsSymbol()) { 86 } else if (name->IsSymbol()) {
87 return "<symbol>"; 87 return "<symbol>";
88 } 88 }
89 return ""; 89 return "";
90 } 90 }
91 91
92 92
93 const char* StringsStorage::GetName(int index) { 93 const char* StringsStorage::GetName(int index) {
(...skipping 20 matching lines...) Expand all
114 return size; 114 return size;
115 } 115 }
116 116
117 117
118 HashMap::Entry* StringsStorage::GetEntry(const char* str, int len) { 118 HashMap::Entry* StringsStorage::GetEntry(const char* str, int len) {
119 uint32_t hash = StringHasher::HashSequentialString(str, len, hash_seed_); 119 uint32_t hash = StringHasher::HashSequentialString(str, len, hash_seed_);
120 return names_.LookupOrInsert(const_cast<char*>(str), hash); 120 return names_.LookupOrInsert(const_cast<char*>(str), hash);
121 } 121 }
122 } // namespace internal 122 } // namespace internal
123 } // namespace v8 123 } // namespace v8
OLDNEW
« BUILD.gn ('K') | « src/string-stream.cc ('k') | test/cctest/compiler/test-operator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698