src/frames.cc - Issue 1221433021: Move SmartPointer to base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames.cc

Issue 1221433021: Move SmartPointer to base. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove some unecessary header includes Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/frames.cc

diff --git a/src/frames.cc b/src/frames.cc

index 723db4ae13c3c6e8da7a173578bd545c6e0ced7b..5dea8484c96ea1318fa15e4bee21f98287e15a5f 100644

--- a/src/frames.cc

+++ b/src/frames.cc

@@ -819,7 +819,7 @@ void JavaScriptFrame::PrintFunctionAndOffset(JSFunction* function, Code* code,

Object* script_name_raw = script->name();

if (script_name_raw->IsString()) {

String* script_name = String::cast(script->name());

- SmartArrayPointer<char> c_script_name =

+ base::SmartArrayPointer<char> c_script_name =

script_name->ToCString(DISALLOW_NULLS, ROBUST_STRING_TRAVERSAL);

PrintF(file, " at %s:%d", c_script_name.get(), line);

} else {

« BUILD.gn ('K') | « src/factory.cc ('k') | src/gdb-jit.cc » ('j') | no next file with comments »