src/factory.cc - Issue 1221433021: Move SmartPointer to base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 1221433021: Move SmartPointer to base. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove some unecessary header includes Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 2b79a5bf8f25a74a8ac37a35efa75fe7427ea86e..dcb2223bb6878cbd74131ee1f7bdf87050cc2f10 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -1150,7 +1150,7 @@ Handle<String> Factory::EmergencyNewError(const char* message,

if (space > 0) {

Handle<String> arg_str = Handle<String>::cast(

Object::GetElement(isolate(), args, i).ToHandleChecked());

- SmartArrayPointer<char> arg = arg_str->ToCString();

+ base::SmartArrayPointer<char> arg = arg_str->ToCString();

Vector<char> v2(p, static_cast<int>(space));

StrNCpy(v2, arg.get(), space);

space -= Min(space, strlen(arg.get()));

« BUILD.gn ('K') | « src/disassembler.cc ('k') | src/frames.cc » ('j') | no next file with comments »