src/disassembler.cc - Issue 1221433021: Move SmartPointer to base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/disassembler.cc

Issue 1221433021: Move SmartPointer to base. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove some unecessary header includes Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/disassembler.cc

diff --git a/src/disassembler.cc b/src/disassembler.cc

index 06eb2397eb8d0ecf6278634f5448206c854055a2..84a0ff9e7e71666e67be3e0cccd3970b2c17a61a 100644

--- a/src/disassembler.cc

+++ b/src/disassembler.cc

@@ -182,7 +182,7 @@ static int DecodeIt(Isolate* isolate, std::ostream* os,

HeapStringAllocator allocator;

StringStream accumulator(&allocator);

relocinfo.target_object()->ShortPrint(&accumulator);

- SmartArrayPointer<const char> obj_name = accumulator.ToCString();

+ base::SmartArrayPointer<const char> obj_name = accumulator.ToCString();

out.AddFormatted(" ;; object: %s", obj_name.get());

} else if (rmode == RelocInfo::EXTERNAL_REFERENCE) {

const char* reference_name = ref_encoder.NameOfAddress(

« BUILD.gn ('K') | « src/deoptimizer.cc ('k') | src/factory.cc » ('j') | no next file with comments »