test/cctest/test-heap-profiler.cc - Issue 1221433021: Move SmartPointer to base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 1221433021: Move SmartPointer to base. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove some unecessary header includes Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-heap-profiler.cc

diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc

index 4416f38973ae1123130fb1f395fd4d5e77d2c34f..a646c7e697727bfe2e4281b7495e75d5cb450e15 100644

--- a/test/cctest/test-heap-profiler.cc

+++ b/test/cctest/test-heap-profiler.cc

@@ -1768,7 +1768,7 @@ TEST(GetHeapValueForDeletedObject) {

static int StringCmp(const char* ref, i::String* act) {

- i::SmartArrayPointer<char> s_act = act->ToCString();

+ v8::base::SmartArrayPointer<char> s_act = act->ToCString();

int result = strcmp(ref, s_act.get());

if (result != 0)

fprintf(stderr, "Expected: \"%s\", Actual: \"%s\"\n", ref, s_act.get());