src/objects-printer.cc - Issue 1221433021: Move SmartPointer to base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-printer.cc

Issue 1221433021: Move SmartPointer to base. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove some unecessary header includes Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-printer.cc

diff --git a/src/objects-printer.cc b/src/objects-printer.cc

index 1dcc3d53948d13cd87f5770f06b04a0320f921ba..c587f7c38931a8bb4c5207eb05ac5a452ea0c784 100644

--- a/src/objects-printer.cc

+++ b/src/objects-printer.cc

@@ -748,10 +748,8 @@ void SharedFunctionInfo::SharedFunctionInfoPrint(std::ostream& os) { // NOLINT

String* source = String::cast(Script::cast(script())->source());

int start = start_position();

int length = end_position() - start;

- SmartArrayPointer<char> source_string =

- source->ToCString(DISALLOW_NULLS,

- FAST_STRING_TRAVERSAL,

- start, length, NULL);

+ base::SmartArrayPointer<char> source_string = source->ToCString(

+ DISALLOW_NULLS, FAST_STRING_TRAVERSAL, start, length, NULL);

os << source_string.get();

}

// Script files are often large, hard to read.

« BUILD.gn ('K') | « src/objects.cc ('k') | src/parser.cc » ('j') | no next file with comments »