BUILD.gn - Issue 1221433021: Move SmartPointer to base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 1221433021: Move SmartPointer to base. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove some unecessary header includes Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 059ee07086248da5ef965c679041e0e0a356e0af..a1ccac86a006687b94a7739c3fa8203e4bab958c 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -1067,7 +1067,6 @@ source_set("v8_base") {

"src/signature.h",

"src/simulator.h",

"src/small-pointer-list.h",

- "src/smart-pointers.h",

"src/snapshot/natives.h",

"src/snapshot/serialize.cc",

"src/snapshot/serialize.h",

@@ -1477,6 +1476,7 @@ source_set("v8_libbase") {

"src/base/safe_conversions_impl.h",

"src/base/safe_math.h",

"src/base/safe_math_impl.h",

+ "src/hase/smart-pointers.h",

Michael Achenbach 2015/07/14 08:35:35 s/hase/base I'll upload a patch and back-merge to

rmcilroy 2015/07/14 09:37:29 oops! Sorry, thanks! p.s. Do we not have a GN bot

"src/base/sys-info.cc",

"src/base/sys-info.h",

"src/base/utils/random-number-generator.cc",

« no previous file with comments | « no previous file | src/arm/codegen-arm.cc » ('j') | no next file with comments »