chrome/test/chromedriver/server/http_handler.cc - Issue 1220963005: Update base::StartsWith calls to new form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/server/http_handler.cc

Issue 1220963005: Update base::StartsWith calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@starts_with

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/server/http_handler.cc

diff --git a/chrome/test/chromedriver/server/http_handler.cc b/chrome/test/chromedriver/server/http_handler.cc

index 77bed0292c48e9c791c0a962a1f15811e998270a..0d54c220505ab675e3dce797dbf9f132b864c787 100644

--- a/chrome/test/chromedriver/server/http_handler.cc

+++ b/chrome/test/chromedriver/server/http_handler.cc

@@ -580,7 +580,7 @@ void HttpHandler::Handle(const net::HttpServerRequestInfo& request,

return;

std::string path = request.path;

- if (!base::StartsWithASCII(path, url_base_, true)) {

+ if (!base::StartsWith(path, url_base_, base::CompareCase::SENSITIVE)) {

scoped_ptr<net::HttpServerResponseInfo> response(

new net::HttpServerResponseInfo(net::HTTP_BAD_REQUEST));

response->SetBody("unhandled request", "text/plain");