chrome/browser/apps/guest_view/web_view_browsertest.cc - Issue 1220963005: Update base::StartsWith calls to new form

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 1220963005: Update base::StartsWith calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@starts_with

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/preferences/website_preference_bridge.cc ('k') | chrome/browser/autofill/autofill_browsertest.cc » ('j') | chrome/browser/autofill/autofill_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/guest_view/web_view_browsertest.cc

diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc

index eed661b157a075591724714a45ec4b120e83dd93..0019d2fd94020d03f4e560376d1aaa234d81eae0 100644

--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc

+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc

@@ -406,13 +406,15 @@ class WebViewTest : public extensions::PlatformAppBrowserTest {

const std::string& path,

const GURL& redirect_target,

const net::test_server::HttpRequest& request) {

- if (!base::StartsWithASCII(path, request.relative_url, true))

+ if (!base::StartsWith(path, request.relative_url,

+ base::CompareCase::SENSITIVE))

return scoped_ptr<net::test_server::HttpResponse>();

std::map<std::string, std::string>::const_iterator it =

request.headers.find("User-Agent");

EXPECT_TRUE(it != request.headers.end());

- if (!base::StartsWithASCII("foobar", it->second, true))

+ if (!base::StartsWith("foobar", it->second,

+ base::CompareCase::SENSITIVE))

return scoped_ptr<net::test_server::HttpResponse>();

scoped_ptr<net::test_server::BasicHttpResponse> http_response(

@@ -427,7 +429,8 @@ class WebViewTest : public extensions::PlatformAppBrowserTest {

const std::string& path,

const GURL& redirect_target,

const net::test_server::HttpRequest& request) {

- if (!base::StartsWithASCII(path, request.relative_url, true))

+ if (!base::StartsWith(path, request.relative_url,

+ base::CompareCase::SENSITIVE))

return scoped_ptr<net::test_server::HttpResponse>();

scoped_ptr<net::test_server::BasicHttpResponse> http_response(

@@ -441,7 +444,8 @@ class WebViewTest : public extensions::PlatformAppBrowserTest {

static scoped_ptr<net::test_server::HttpResponse> EmptyResponseHandler(

const std::string& path,

const net::test_server::HttpRequest& request) {

- if (base::StartsWithASCII(path, request.relative_url, true))

+ if (base::StartsWith(path, request.relative_url,

+ base::CompareCase::SENSITIVE))

return scoped_ptr<net::test_server::HttpResponse>(new EmptyHttpResponse);

return scoped_ptr<net::test_server::HttpResponse>();

@@ -451,7 +455,8 @@ class WebViewTest : public extensions::PlatformAppBrowserTest {

static scoped_ptr<net::test_server::HttpResponse> CacheControlResponseHandler(

const std::string& path,

const net::test_server::HttpRequest& request) {

- if (!base::StartsWithASCII(path, request.relative_url, true))

+ if (!base::StartsWith(path, request.relative_url,

+ base::CompareCase::SENSITIVE))

return scoped_ptr<net::test_server::HttpResponse>();

scoped_ptr<net::test_server::BasicHttpResponse> http_response(