Update base::StartsWith calls to new form

chrome/browser/autofill/autofill_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/memory/ref_counted.h"
@@ skipping 228 matching lines @@
 
     std::string data;
     base::FilePath data_file =
         ui_test_utils::GetTestFilePath(base::FilePath().AppendASCII("autofill"),
                                        base::FilePath().AppendASCII(filename));
     CHECK(base::ReadFileToString(data_file, &data));
     std::vector<std::string> lines;
     base::SplitString(data, '\n', &lines);
     int parsed_profiles = 0;
     for (size_t i = 0; i < lines.size(); ++i) {
-      if (base::StartsWithASCII(lines[i], "#", false))
+      if (base::StartsWith(lines[i], "#", base::CompareCase::SENSITIVE))
         continue;
 
-      std::vector<std::string> fields;
-      base::SplitString(lines[i], '|', &fields);
+      std::vector<std::string> fields = base::SplitString(
+          lines[i], "|", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

[Nico, 2015/07/06 17:55:00]

this is unrelated?

[brettw, 2015/07/06 18:23:34]

Oh yeah, I've been doing both SplitString and StartsWith updates, but this patch
got too big so I stopped. It ended up I only changed a few SplitString calls
where I was changing StartsWith already. I added a note to this effect in the CL
description.

       if (fields.empty())
         continue;  // Blank line.
 
       ++parsed_profiles;
       CHECK_EQ(12u, fields.size());
 
       FormMap data;
       data["NAME_FIRST"] = fields[0];
       data["NAME_MIDDLE"] = fields[1];
       data["NAME_LAST"] = fields[2];
@@ skipping 679 matching lines @@
 IN_PROC_BROWSER_TEST_F(AutofillTest,
                        DISABLED_MergeAggregatedDuplicatedProfiles) {
   int num_of_profiles =
       AggregateProfilesIntoAutofillPrefs("dataset_duplicated_profiles.txt");
 
   ASSERT_GT(num_of_profiles,
             static_cast<int>(personal_data_manager()->GetProfiles().size()));
 }
 
 }  // namespace autofill