chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc - Issue 1220963005: Update base::StartsWith calls to new form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc

Issue 1220963005: Update base::StartsWith calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@starts_with

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/extension_action/extension_action_api.cc ('K') | « chrome/browser/net/safe_search_util.cc ('k') | chrome/browser/password_manager/password_manager_browsertest.cc » ('j') | chrome/utility/importer/bookmark_html_reader.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc

diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc

index 1ceb296a2f557693381d53234d9c4b6b8c7e0ef6..991c32bc7fd1678268965eefede5d32be75bfd6a 100644

--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc

+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc

@@ -67,7 +67,8 @@ bool GetEmbeddedPacScript(const std::string& pac_url, std::string* pac_script) {

DCHECK(pac_script);

const std::string kPacURLPrefix =

"data:application/x-ns-proxy-autoconfig;base64,";

- return base::StartsWithASCII(pac_url, kPacURLPrefix, true) &&

+ return base::StartsWith(pac_url, kPacURLPrefix,

+ base::CompareCase::SENSITIVE) &&

base::Base64Decode(pac_url.substr(kPacURLPrefix.size()), pac_script);

}