chrome/browser/extensions/extension_protocols_unittest.cc - Issue 1220963005: Update base::StartsWith calls to new form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_protocols_unittest.cc

Issue 1220963005: Update base::StartsWith calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@starts_with

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_protocols_unittest.cc

diff --git a/chrome/browser/extensions/extension_protocols_unittest.cc b/chrome/browser/extensions/extension_protocols_unittest.cc

index ab30636e9590ead3fd033827c8b9cda82579d16b..e057b0450766b3089e4fa73e7b008df5581005b8 100644

--- a/chrome/browser/extensions/extension_protocols_unittest.cc

+++ b/chrome/browser/extensions/extension_protocols_unittest.cc

@@ -298,8 +298,8 @@ TEST_F(ExtensionProtocolTest, ResourceRequestResponseHeaders) {

// Check that cache-related headers are set.

std::string etag;

request->GetResponseHeaderByName("ETag", &etag);

- EXPECT_TRUE(base::StartsWithASCII(etag, "\"", false));

- EXPECT_TRUE(base::EndsWith(etag, "\"", false));

+ EXPECT_TRUE(base::StartsWith(etag, "\"", base::CompareCase::SENSITIVE));

+ EXPECT_TRUE(base::EndsWith(etag, "\"", base::CompareCase::SENSITIVE));

std::string revalidation_header;

request->GetResponseHeaderByName("cache-control", &revalidation_header);