chrome/browser/ui/omnibox/omnibox_view.cc - Issue 1220963005: Update base::StartsWith calls to new form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_view.cc

Issue 1220963005: Update base::StartsWith calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@starts_with

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/omnibox/omnibox_view.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_view.cc b/chrome/browser/ui/omnibox/omnibox_view.cc

index 02e33029eb4850f9989ccf9801c337bc7f7c8fc4..7c6961413e0705c5fa43fc6c0a3aa47e8a3d7a9d 100644

--- a/chrome/browser/ui/omnibox/omnibox_view.cc

+++ b/chrome/browser/ui/omnibox/omnibox_view.cc

@@ -28,7 +28,8 @@ base::string16 OmniboxView::StripJavascriptSchemas(const base::string16& text) {

const base::string16 kJsPrefix(

base::ASCIIToUTF16(url::kJavaScriptScheme) + base::ASCIIToUTF16(":"));

base::string16 out(text);

- while (base::StartsWith(out, kJsPrefix, false)) {

+ while (base::StartsWith(out, kJsPrefix,

+ base::CompareCase::INSENSITIVE_ASCII)) {

base::TrimWhitespace(out.substr(kJsPrefix.length()), base::TRIM_LEADING,

&out);

}