chrome/browser/ui/webui/ntp/favicon_webui_handler.cc - Issue 1220963005: Update base::StartsWith calls to new form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/favicon_webui_handler.cc

Issue 1220963005: Update base::StartsWith calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@starts_with

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/ntp/favicon_webui_handler.cc

diff --git a/chrome/browser/ui/webui/ntp/favicon_webui_handler.cc b/chrome/browser/ui/webui/ntp/favicon_webui_handler.cc

index dcb600d5ab6a3ed3095707eba2b3446dbfbde34b..27e71a40fd3b150093ceae476cd00801a986c551 100644

--- a/chrome/browser/ui/webui/ntp/favicon_webui_handler.cc

+++ b/chrome/browser/ui/webui/ntp/favicon_webui_handler.cc

@@ -84,7 +84,8 @@ void FaviconWebUIHandler::HandleGetFaviconDominantColor(

std::string path;

CHECK(args->GetString(0, &path));

std::string prefix = "chrome://favicon/size/";

- DCHECK(base::StartsWithASCII(path, prefix, false)) << "path is " << path;

+ DCHECK(base::StartsWith(path, prefix, base::CompareCase::INSENSITIVE_ASCII))

+ << "path is " << path;

size_t slash = path.find("/", prefix.length());

path = path.substr(slash + 1);