Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1197723002: NodeFilter acceptNode return type changed to unsigned (Closed)

Created:
5 years, 6 months ago by Habib Virji
Modified:
5 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, blink-reviews-bindings_chromium.org, philipj_slow, Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

NodeFilter acceptNode return type changed to unsigned acceptNode return type was set to short. It has been updated to return unsigned. acceptNode returns enum value and thus change is more to comply with the specification without much impact. The usage in the NodeIterator and TreeWalker was also expecting short return value and has been updated to unsigned. BUG=496400 R=philipj, rbyers Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197693

Patch Set 1 #

Patch Set 2 : Change sign in the calls for NodeFIlter.acceptNode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -28 lines) Patch
M Source/bindings/core/v8/V8NodeFilterCondition.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8NodeFilterCondition.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/NodeFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeFilter.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/dom/NodeFilter.idl View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/dom/NodeFilterCondition.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeIteratorBase.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeIteratorBase.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeWalker.cpp View 1 11 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197723002/1
5 years, 6 months ago (2015-06-19 13:35:51 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59774)
5 years, 6 months ago (2015-06-19 15:05:10 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197723002/20001
5 years, 6 months ago (2015-06-22 15:41:05 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-22 16:34:26 UTC) #8
Habib Virji
PTAL.
5 years, 6 months ago (2015-06-23 08:13:49 UTC) #10
Rick Byers
We should probably get an OWNER from DOM-team for all these DOM API tweaks (I ...
5 years, 6 months ago (2015-06-23 21:08:50 UTC) #12
tkent
lgtm
5 years, 6 months ago (2015-06-23 23:22:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197723002/20001
5 years, 6 months ago (2015-06-23 23:22:36 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 02:00:40 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197693

Powered by Google App Engine
This is Rietveld 408576698