Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Side by Side Diff: Source/core/dom/NodeFilter.idl

Issue 1197723002: NodeFilter acceptNode return type changed to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Change sign in the calls for NodeFIlter.acceptNode Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/NodeFilter.cpp ('k') | Source/core/dom/NodeFilterCondition.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Library General Public License for more details. 13 * Library General Public License for more details.
14 * 14 *
15 * You should have received a copy of the GNU Library General Public License 15 * You should have received a copy of the GNU Library General Public License
16 * along with this library; see the file COPYING.LIB. If not, write to 16 * along with this library; see the file COPYING.LIB. If not, write to
17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18 * Boston, MA 02110-1301, USA. 18 * Boston, MA 02110-1301, USA.
19 */ 19 */
20 20
21 // https://dom.spec.whatwg.org/#interface-nodefilter 21 // https://dom.spec.whatwg.org/#interface-nodefilter
22 22
23 // FIXME: NodeFilter should be a callback interface. crbug.com/462946 23 // FIXME: NodeFilter should be a callback interface. crbug.com/462946
24 [ 24 [
25 DependentLifetime, 25 DependentLifetime,
26 WillBeGarbageCollected, 26 WillBeGarbageCollected,
27 ] interface NodeFilter { 27 ] interface NodeFilter {
28 // Constants for acceptNode() 28 // Constants for acceptNode()
29 // FIXME: acceptNode()'s return type and these constants should be unsigned short. 29 const unsigned short FILTER_ACCEPT = 1;
30 const short FILTER_ACCEPT = 1; 30 const unsigned short FILTER_REJECT = 2;
31 const short FILTER_REJECT = 2; 31 const unsigned short FILTER_SKIP = 3;
32 const short FILTER_SKIP = 3;
33 32
34 // Constants for whatToShow 33 // Constants for whatToShow
35 const unsigned long SHOW_ALL = 0xFFFFFFFF; 34 const unsigned long SHOW_ALL = 0xFFFFFFFF;
36 const unsigned long SHOW_ELEMENT = 0x1; 35 const unsigned long SHOW_ELEMENT = 0x1;
37 const unsigned long SHOW_ATTRIBUTE = 0x2; // historical 36 const unsigned long SHOW_ATTRIBUTE = 0x2; // historical
38 const unsigned long SHOW_TEXT = 0x4; 37 const unsigned long SHOW_TEXT = 0x4;
39 const unsigned long SHOW_CDATA_SECTION = 0x8; // historical 38 const unsigned long SHOW_CDATA_SECTION = 0x8; // historical
40 const unsigned long SHOW_ENTITY_REFERENCE = 0x10; // historical 39 const unsigned long SHOW_ENTITY_REFERENCE = 0x10; // historical
41 const unsigned long SHOW_ENTITY = 0x20; // historical 40 const unsigned long SHOW_ENTITY = 0x20; // historical
42 const unsigned long SHOW_PROCESSING_INSTRUCTION = 0x40; 41 const unsigned long SHOW_PROCESSING_INSTRUCTION = 0x40;
43 const unsigned long SHOW_COMMENT = 0x80; 42 const unsigned long SHOW_COMMENT = 0x80;
44 const unsigned long SHOW_DOCUMENT = 0x100; 43 const unsigned long SHOW_DOCUMENT = 0x100;
45 const unsigned long SHOW_DOCUMENT_TYPE = 0x200; 44 const unsigned long SHOW_DOCUMENT_TYPE = 0x200;
46 const unsigned long SHOW_DOCUMENT_FRAGMENT = 0x400; 45 const unsigned long SHOW_DOCUMENT_FRAGMENT = 0x400;
47 const unsigned long SHOW_NOTATION = 0x800; // historical 46 const unsigned long SHOW_NOTATION = 0x800; // historical
48 47
49 // FIXME: The node argument should not be optional. 48 // FIXME: The node argument should not be optional.
50 [RaisesException] short acceptNode([Default=Undefined] optional Node node); 49 [RaisesException] unsigned short acceptNode([Default=Undefined] optional Nod e node);
51 }; 50 };
OLDNEW
« no previous file with comments | « Source/core/dom/NodeFilter.cpp ('k') | Source/core/dom/NodeFilterCondition.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698