Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: Source/bindings/core/v8/V8NodeFilterCondition.cpp

Issue 1197723002: NodeFilter acceptNode return type changed to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Change sign in the calls for NodeFIlter.acceptNode Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8NodeFilterCondition.h ('k') | Source/core/dom/NodeFilter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8NodeFilterCondition.cpp
diff --git a/Source/bindings/core/v8/V8NodeFilterCondition.cpp b/Source/bindings/core/v8/V8NodeFilterCondition.cpp
index 3128311990ce6080cfc986da6bd3839fb4915f89..43373c429b9708f9ad19bc0d1d4b14ac4daaabd3 100644
--- a/Source/bindings/core/v8/V8NodeFilterCondition.cpp
+++ b/Source/bindings/core/v8/V8NodeFilterCondition.cpp
@@ -57,7 +57,7 @@ V8NodeFilterCondition::~V8NodeFilterCondition()
{
}
-short V8NodeFilterCondition::acceptNode(Node* node, ExceptionState& exceptionState) const
+unsigned V8NodeFilterCondition::acceptNode(Node* node, ExceptionState& exceptionState) const
{
v8::Isolate* isolate = m_scriptState->isolate();
ASSERT(!m_scriptState->context().IsEmpty());
@@ -106,12 +106,12 @@ short V8NodeFilterCondition::acceptNode(Node* node, ExceptionState& exceptionSta
ASSERT(!result.IsEmpty());
- int32_t int32Value;
- if (!v8Call(result->Int32Value(m_scriptState->context()), int32Value, exceptionCatcher)) {
+ uint32_t uint32Value;
+ if (!v8Call(result->Uint32Value(m_scriptState->context()), uint32Value, exceptionCatcher)) {
exceptionState.rethrowV8Exception(exceptionCatcher.Exception());
return NodeFilter::FILTER_REJECT;
}
- return int32Value;
+ return uint32Value;
}
void V8NodeFilterCondition::setWeakCallback(const v8::WeakCallbackInfo<V8NodeFilterCondition>& data)
« no previous file with comments | « Source/bindings/core/v8/V8NodeFilterCondition.h ('k') | Source/core/dom/NodeFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698