Source/bindings/core/v8/V8NodeFilterCondition.h - Issue 1197723002: NodeFilter acceptNode return type changed to unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8NodeFilterCondition.h

Issue 1197723002: NodeFilter acceptNode return type changed to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Change sign in the calls for NodeFIlter.acceptNode Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8NodeFilterCondition.h

diff --git a/Source/bindings/core/v8/V8NodeFilterCondition.h b/Source/bindings/core/v8/V8NodeFilterCondition.h

index 88c6b42bc4f36821f5a4d162e19aaef099011b88..54d3de69012dd895485d4e5f3dd40b00610f9bfd 100644

--- a/Source/bindings/core/v8/V8NodeFilterCondition.h

+++ b/Source/bindings/core/v8/V8NodeFilterCondition.h

@@ -69,7 +69,7 @@ public:

virtual ~V8NodeFilterCondition();

- virtual short acceptNode(Node*, ExceptionState&) const override;

+ virtual unsigned acceptNode(Node*, ExceptionState&) const override;

private:

// As the value |filter| is maintained by V8GC, the |owner| which references

« no previous file with comments | « no previous file | Source/bindings/core/v8/V8NodeFilterCondition.cpp » ('j') | no next file with comments »