Source/core/dom/NodeFilterCondition.h - Issue 1197723002: NodeFilter acceptNode return type changed to unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/NodeFilterCondition.h

Issue 1197723002: NodeFilter acceptNode return type changed to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Change sign in the calls for NodeFIlter.acceptNode Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/NodeFilterCondition.h

diff --git a/Source/core/dom/NodeFilterCondition.h b/Source/core/dom/NodeFilterCondition.h

index e87837c0bdadb5f858a081865b5d91f0155bca48..77764bdbb4eba90d5049259c3f74bdf271870fe3 100644

--- a/Source/core/dom/NodeFilterCondition.h

+++ b/Source/core/dom/NodeFilterCondition.h

@@ -36,7 +36,7 @@ class Node;

class NodeFilterCondition : public RefCountedWillBeGarbageCollectedFinalized<NodeFilterCondition> {

public:

virtual ~NodeFilterCondition() { }

- virtual short acceptNode(Node*, ExceptionState&) const = 0;

+ virtual unsigned acceptNode(Node*, ExceptionState&) const = 0;

DEFINE_INLINE_VIRTUAL_TRACE() { }

};

« no previous file with comments | « Source/core/dom/NodeFilter.idl ('k') | Source/core/dom/NodeIteratorBase.h » ('j') | no next file with comments »