Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: Source/core/dom/NodeFilter.idl

Issue 1197723002: NodeFilter acceptNode return type changed to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Change sign in the calls for NodeFIlter.acceptNode Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/NodeFilter.cpp ('k') | Source/core/dom/NodeFilterCondition.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/NodeFilter.idl
diff --git a/Source/core/dom/NodeFilter.idl b/Source/core/dom/NodeFilter.idl
index d4320655e493cca6403a3b8e96fc9fe5eaed54f8..3fe66ea40c928c2031105a83fcad1c727718edd9 100644
--- a/Source/core/dom/NodeFilter.idl
+++ b/Source/core/dom/NodeFilter.idl
@@ -26,10 +26,9 @@
WillBeGarbageCollected,
] interface NodeFilter {
// Constants for acceptNode()
- // FIXME: acceptNode()'s return type and these constants should be unsigned short.
- const short FILTER_ACCEPT = 1;
- const short FILTER_REJECT = 2;
- const short FILTER_SKIP = 3;
+ const unsigned short FILTER_ACCEPT = 1;
+ const unsigned short FILTER_REJECT = 2;
+ const unsigned short FILTER_SKIP = 3;
// Constants for whatToShow
const unsigned long SHOW_ALL = 0xFFFFFFFF;
@@ -47,5 +46,5 @@
const unsigned long SHOW_NOTATION = 0x800; // historical
// FIXME: The node argument should not be optional.
- [RaisesException] short acceptNode([Default=Undefined] optional Node node);
+ [RaisesException] unsigned short acceptNode([Default=Undefined] optional Node node);
};
« no previous file with comments | « Source/core/dom/NodeFilter.cpp ('k') | Source/core/dom/NodeFilterCondition.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698