Source/core/dom/NodeFilter.cpp - Issue 1197723002: NodeFilter acceptNode return type changed to unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/NodeFilter.cpp

Issue 1197723002: NodeFilter acceptNode return type changed to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Change sign in the calls for NodeFIlter.acceptNode Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/NodeFilter.cpp

diff --git a/Source/core/dom/NodeFilter.cpp b/Source/core/dom/NodeFilter.cpp

index 372ea5c5e7a8a2ee8871b400a07d32e74a3a8e8c..50509dfeeb060004db67726fface8654d6b5c005 100644

--- a/Source/core/dom/NodeFilter.cpp

+++ b/Source/core/dom/NodeFilter.cpp

@@ -27,10 +27,9 @@

namespace blink {

-short NodeFilter::acceptNode(Node* node, ExceptionState& exceptionState) const

+unsigned NodeFilter::acceptNode(Node* node, ExceptionState& exceptionState) const

{

- // cast to short silences "enumeral and non-enumeral types in return" warning

- return m_condition ? m_condition->acceptNode(node, exceptionState) : static_cast<short>(FILTER_ACCEPT);

+ return m_condition ? m_condition->acceptNode(node, exceptionState) : FILTER_ACCEPT;

}

DEFINE_TRACE(NodeFilter)

« no previous file with comments | « Source/core/dom/NodeFilter.h ('k') | Source/core/dom/NodeFilter.idl » ('j') | no next file with comments »