Source/core/dom/NodeIteratorBase.cpp - Issue 1197723002: NodeFilter acceptNode return type changed to unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/NodeIteratorBase.cpp

Issue 1197723002: NodeFilter acceptNode return type changed to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Change sign in the calls for NodeFIlter.acceptNode Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/NodeIteratorBase.cpp

diff --git a/Source/core/dom/NodeIteratorBase.cpp b/Source/core/dom/NodeIteratorBase.cpp

index 0fc07a76c831df4672a925319df143200036c21e..fe1cd617442b7f605fa1cffa4193ba0f4a9091ac 100644

--- a/Source/core/dom/NodeIteratorBase.cpp

+++ b/Source/core/dom/NodeIteratorBase.cpp

@@ -40,7 +40,7 @@ NodeIteratorBase::NodeIteratorBase(PassRefPtrWillBeRawPtr<Node> rootNode, unsign

{

}

-short NodeIteratorBase::acceptNode(Node* node, ExceptionState& exceptionState) const

+unsigned NodeIteratorBase::acceptNode(Node* node, ExceptionState& exceptionState) const

{

// The bit twiddling here is done to map DOM node types, which are given as integers from

// 1 through 14, to whatToShow bit masks.

« no previous file with comments | « Source/core/dom/NodeIteratorBase.h ('k') | Source/core/dom/TreeWalker.cpp » ('j') | no next file with comments »