Removes ServiceProviders from ViewManager::Embed

Removes ServiceProviders from ViewManager::Embed

We're left with the following:
. Embed(ViewManagerClientPtr client)
. EmbedAllowingReembed(mojo::URLRequestPtr request): this variant
  walks the frame tree for the first ancestor marked as an embed root
  and asks it for the ViewManagerclient to embed.

BUG=497855
TEST=covered by tests
R=ben@chromium.org

Committed: https://crrev.com/4f36e252548209ff1a9d7e2cb7102030091e5bde
Cr-Commit-Position: refs/heads/master@{#333660}

[Ben Goodger (Google), 2015-06-09 20:27:27]

https://codereview.chromium.org/1166123005/diff/20001/components/html_viewer/...
File components/html_viewer/html_viewer.cc (right):

https://codereview.chromium.org/1166123005/diff/20001/components/html_viewer/...
components/html_viewer/html_viewer.cc:169: connection->GetRemoteApplicationURL()
!= "mojo://browser/") {
oof this feels like a layering violation.

seems like this just controls whether some resources are loaded. can that just
always be done even for tests? that'd make this much simpler & remove the
layering violation.

[sky, 2015-06-09 21:35:31]

https://codereview.chromium.org/1166123005/diff/20001/components/html_viewer/...
File components/html_viewer/html_viewer.cc (right):

https://codereview.chromium.org/1166123005/diff/20001/components/html_viewer/...
components/html_viewer/html_viewer.cc:169: connection->GetRemoteApplicationURL()
!= "mojo://browser/") {
On 2015/06/09 20:27:27, Ben Goodger (Google) wrote:
> oof this feels like a layering violation.
> 
> seems like this just controls whether some resources are loaded. can that just
> always be done even for tests? that'd make this much simpler & remove the
> layering violation.

It's more subtle than that. But, we have a switch for headless already. So, I
added that to running the apptest and we're good. This code has been nuked.

[Ben Goodger (Google), 2015-06-09 22:21:48]

lgtm

[sky, 2015-06-09 22:23:09]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2015-06-09 22:25:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1166123005/40001

[commit-bot: I haz the power, 2015-06-10 02:30:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-10 02:32:03]

Patchset 3 (id:??) landed as
https://crrev.com/4f36e252548209ff1a9d7e2cb7102030091e5bde
Cr-Commit-Position: refs/heads/master@{#333660}