components/view_manager/public/cpp/view.h - Issue 1166123005: Removes ServiceProviders from ViewManager::Embed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/view_manager/public/cpp/view.h

Issue 1166123005: Removes ServiceProviders from ViewManager::Embed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use is_headless rather than check for browser. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/view_manager/public/cpp/view.h

diff --git a/components/view_manager/public/cpp/view.h b/components/view_manager/public/cpp/view.h

index bf519eee525d26eb56474455172ea1c54bc4db34..7629a0c3e592dfa8c3478046130e4e14747f6561 100644

--- a/components/view_manager/public/cpp/view.h

+++ b/components/view_manager/public/cpp/view.h

@@ -129,10 +129,6 @@ class View {

void SetFocus();

// Embedding. See view_manager.mojom for details.

- void Embed(const String& url);

- void Embed(mojo::URLRequestPtr request,

- InterfaceRequest<ServiceProvider> services,

- ServiceProviderPtr exposed_services);

void Embed(ViewManagerClientPtr client);

void EmbedAllowingReembed(mojo::URLRequestPtr request);