mandoline/ui/omnibox/omnibox_impl.h - Issue 1166123005: Removes ServiceProviders from ViewManager::Embed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mandoline/ui/omnibox/omnibox_impl.h

Issue 1166123005: Removes ServiceProviders from ViewManager::Embed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use is_headless rather than check for browser. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mandoline/ui/omnibox/omnibox_impl.h

diff --git a/mandoline/ui/omnibox/omnibox_impl.h b/mandoline/ui/omnibox/omnibox_impl.h

index d6206d416b25db2e805777c27eb4a8c5293d9a1e..249b6ddf34295d95ba74ebfe846ca7694fc1bea1 100644

--- a/mandoline/ui/omnibox/omnibox_impl.h

+++ b/mandoline/ui/omnibox/omnibox_impl.h

@@ -41,9 +41,7 @@ class OmniboxImpl : public mojo::ApplicationDelegate,

mojo::ApplicationConnection* connection) override;

// Overridden from mojo::ViewManagerDelegate:

- void OnEmbed(mojo::View* root,

- mojo::InterfaceRequest<mojo::ServiceProvider> services,

- mojo::ServiceProviderPtr exposed_services) override;

+ void OnEmbed(mojo::View* root) override;

void OnViewManagerDestroyed(mojo::ViewManager* view_manager) override;

// Overridden from views::LayoutManager:

« no previous file with comments | « mandoline/ui/browser/view_embedder.mojom ('k') | mandoline/ui/omnibox/omnibox_impl.cc » ('j') | no next file with comments »