components/view_manager/public/cpp/view_manager.h - Issue 1166123005: Removes ServiceProviders from ViewManager::Embed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/view_manager/public/cpp/view_manager.h

Issue 1166123005: Removes ServiceProviders from ViewManager::Embed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use is_headless rather than check for browser. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/view_manager/public/cpp/view_manager.h

diff --git a/components/view_manager/public/cpp/view_manager.h b/components/view_manager/public/cpp/view_manager.h

index 78dcab9e23d360ef745ad166fbde0d323529b0bc..7841f4175d15290ee494bb594415cca39b0b0c36 100644

--- a/components/view_manager/public/cpp/view_manager.h

+++ b/components/view_manager/public/cpp/view_manager.h

@@ -18,9 +18,6 @@ class ViewManager {

public:

virtual ~ViewManager() {}

- // Returns the URL of the application that embedded this application.

- virtual const std::string& GetEmbedderURL() const = 0;

// Returns the root of this connection.

virtual View* GetRoot() = 0;