components/view_manager/public/cpp/lib/view.cc - Issue 1166123005: Removes ServiceProviders from ViewManager::Embed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/view_manager/public/cpp/lib/view.cc

Issue 1166123005: Removes ServiceProviders from ViewManager::Embed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use is_headless rather than check for browser. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/view_manager/public/cpp/lib/view.cc

diff --git a/components/view_manager/public/cpp/lib/view.cc b/components/view_manager/public/cpp/lib/view.cc

index 3497dfaea9341b0f48f4754f957951dbc2c75259..dc4d5e8e21d74a8d6381daf5f3726b2dc00a5234 100644

--- a/components/view_manager/public/cpp/lib/view.cc

+++ b/components/view_manager/public/cpp/lib/view.cc

@@ -366,20 +366,6 @@ void View::SetFocus() {

static_cast<ViewManagerClientImpl*>(manager_)->SetFocus(id_);

}

-void View::Embed(const String& url) {

- if (PrepareForEmbed())

- static_cast<ViewManagerClientImpl*>(manager_)->Embed(url, id_);

-void View::Embed(mojo::URLRequestPtr request,

- InterfaceRequest<ServiceProvider> services,

- ServiceProviderPtr exposed_services) {

- if (PrepareForEmbed()) {

- static_cast<ViewManagerClientImpl*>(manager_)

- ->Embed(request.Pass(), id_, services.Pass(), exposed_services.Pass());

- }

void View::Embed(ViewManagerClientPtr client) {

if (PrepareForEmbed())

static_cast<ViewManagerClientImpl*>(manager_)->Embed(id_, client.Pass());