components/view_manager/view_manager_app.h - Issue 1166123005: Removes ServiceProviders from ViewManager::Embed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/view_manager/view_manager_app.h

Issue 1166123005: Removes ServiceProviders from ViewManager::Embed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use is_headless rather than check for browser. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/view_manager/view_manager_app.h

diff --git a/components/view_manager/view_manager_app.h b/components/view_manager/view_manager_app.h

index a2fa9dd60decb912656c19e8552f574cfe3eb2cb..c86765cd3cf3e37befc7c6d128af8b868a09ccda 100644

--- a/components/view_manager/view_manager_app.h

+++ b/components/view_manager/view_manager_app.h

@@ -49,14 +49,12 @@ class ViewManagerApp : public mojo::ApplicationDelegate,

ConnectionManager* connection_manager,

mojo::InterfaceRequest<mojo::ViewManagerService> service_request,

mojo::ConnectionSpecificId creator_id,

- const std::string& creator_url,

mojo::URLRequestPtr request,

const ViewId& root_id) override;

ClientConnection* CreateClientConnectionForEmbedAtView(

ConnectionManager* connection_manager,

mojo::InterfaceRequest<mojo::ViewManagerService> service_request,

mojo::ConnectionSpecificId creator_id,

- const std::string& creator_url,

const ViewId& root_id,

mojo::ViewManagerClientPtr view_manager_client) override;