Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Unified Diff: components/view_manager/connection_manager.cc

Issue 1166123005: Removes ServiceProviders from ViewManager::Embed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use is_headless rather than check for browser. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/view_manager/connection_manager.h ('k') | components/view_manager/connection_manager_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/view_manager/connection_manager.cc
diff --git a/components/view_manager/connection_manager.cc b/components/view_manager/connection_manager.cc
index 11c547d4f15d0cd005a011e6b9caaef0b0457628..a4ddfc33d5aab0b8dfe164f69e9012dee8d95f87 100644
--- a/components/view_manager/connection_manager.cc
+++ b/components/view_manager/connection_manager.cc
@@ -176,45 +176,29 @@ void ConnectionManager::OnConnectionError(ClientConnection* connection) {
}
}
-void ConnectionManager::EmbedAtView(
- ConnectionSpecificId creator_id,
- mojo::URLRequestPtr request,
- const ViewId& view_id,
- mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::ServiceProviderPtr exposed_services) {
- std::string creator_url;
- ConnectionMap::const_iterator it = connection_map_.find(creator_id);
- if (it != connection_map_.end())
- creator_url = it->second->service()->url();
-
+void ConnectionManager::EmbedAtView(mojo::ConnectionSpecificId creator_id,
+ const ViewId& view_id,
+ mojo::URLRequestPtr request) {
mojo::ViewManagerServicePtr service_ptr;
ClientConnection* client_connection =
delegate_->CreateClientConnectionForEmbedAtView(
- this, GetProxy(&service_ptr), creator_id, creator_url, request.Pass(),
- view_id);
+ this, GetProxy(&service_ptr), creator_id, request.Pass(), view_id);
AddConnection(client_connection);
client_connection->service()->Init(client_connection->client(),
- service_ptr.Pass(), services.Pass(),
- exposed_services.Pass());
+ service_ptr.Pass());
OnConnectionMessagedClient(client_connection->service()->id());
}
void ConnectionManager::EmbedAtView(mojo::ConnectionSpecificId creator_id,
const ViewId& view_id,
mojo::ViewManagerClientPtr client) {
- std::string creator_url;
- ConnectionMap::const_iterator it = connection_map_.find(creator_id);
- if (it != connection_map_.end())
- creator_url = it->second->service()->url();
-
mojo::ViewManagerServicePtr service_ptr;
ClientConnection* client_connection =
delegate_->CreateClientConnectionForEmbedAtView(
- this, GetProxy(&service_ptr), creator_id, creator_url, view_id,
- client.Pass());
+ this, GetProxy(&service_ptr), creator_id, view_id, client.Pass());
AddConnection(client_connection);
client_connection->service()->Init(client_connection->client(),
- service_ptr.Pass(), nullptr, nullptr);
+ service_ptr.Pass());
OnConnectionMessagedClient(client_connection->service()->id());
}
@@ -284,7 +268,7 @@ void ConnectionManager::SetWindowManagerClientConnection(
window_manager_client_connection_ = connection.release();
AddConnection(window_manager_client_connection_);
window_manager_client_connection_->service()->Init(
- window_manager_client_connection_->client(), nullptr, nullptr, nullptr);
+ window_manager_client_connection_->client(), nullptr);
}
mojo::ViewManagerClient*
« no previous file with comments | « components/view_manager/connection_manager.h ('k') | components/view_manager/connection_manager_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698