Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: mandoline/ui/omnibox/omnibox_impl.cc

Issue 1166123005: Removes ServiceProviders from ViewManager::Embed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use is_headless rather than check for browser. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mandoline/ui/omnibox/omnibox_impl.h ('k') | mojo/application/public/cpp/lazy_interface_ptr.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mandoline/ui/omnibox/omnibox_impl.cc
diff --git a/mandoline/ui/omnibox/omnibox_impl.cc b/mandoline/ui/omnibox/omnibox_impl.cc
index edeef04d32be828e659fd8331a4ea7c65dafced6..05096931eab6afa9fd434472b97e87f55e2aea98 100644
--- a/mandoline/ui/omnibox/omnibox_impl.cc
+++ b/mandoline/ui/omnibox/omnibox_impl.cc
@@ -51,9 +51,7 @@ bool OmniboxImpl::ConfigureOutgoingConnection(
////////////////////////////////////////////////////////////////////////////////
// OmniboxImpl, mojo::ViewManagerDelegate implementation:
-void OmniboxImpl::OnEmbed(mojo::View* root,
- mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::ServiceProviderPtr exposed_services) {
+void OmniboxImpl::OnEmbed(mojo::View* root) {
if (!aura_init_.get()) {
aura_init_.reset(new AuraInit(app_impl_->shell()));
edit_ = new views::Textfield;
@@ -138,7 +136,7 @@ void OmniboxImpl::ShowForURL(const mojo::String& url) {
url_ = url;
mojo::URLRequestPtr request(mojo::URLRequest::New());
request->url = mojo::String::From("mojo:omnibox");
- view_embedder_->Embed(request.Pass(), nullptr, nullptr);
+ view_embedder_->Embed(request.Pass());
}
} // namespace mandoline
« no previous file with comments | « mandoline/ui/omnibox/omnibox_impl.h ('k') | mojo/application/public/cpp/lazy_interface_ptr.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698