Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1665)

Issue 1163173002: Pull methods upwards from ChromeTabCreator. (Closed)

Created:
5 years, 6 months ago by gone
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pull methods upwards from ChromeTabCreator. Pulls methods from the Impl into the Interface so that ChromeActivity can take in a generic TabCreator instead of a ChromeTabCreator implementation. This is prep work for making it so that document mode's TabDelegate is also a TabCreator, which will let it be usable in webapp mode for handling window.open calls. BUG=451453 Committed: https://crrev.com/ae9ed0ff595735197f9e4042a844be0324da92dd Cr-Commit-Position: refs/heads/master@{#333094}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fixed the rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -59 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabCreatorManager.java View 2 chunks +34 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeActivity.java View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/CompositorChromeActivity.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/KeyboardShortcuts.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentTab.java View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentWebContentsDelegate.java View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java View 5 chunks +7 lines, -23 lines 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java View 1 3 chunks +10 lines, -7 lines 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/widget/emptybackground/EmptyBackgroundViewTablet.java View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/widget/emptybackground/EmptyBackgroundViewWrapper.java View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/javatests_shell/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java View 1 2 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
gone
Dave: I put some TODOs in here to explain what's going to be happening with ...
5 years, 6 months ago (2015-06-05 01:18:27 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 6 months ago (2015-06-05 05:38:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163173002/1
5 years, 6 months ago (2015-06-05 15:37:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/30500)
5 years, 6 months ago (2015-06-05 16:12:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163173002/40001
5 years, 6 months ago (2015-06-05 17:50:02 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-05 18:24:31 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 18:35:14 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ae9ed0ff595735197f9e4042a844be0324da92dd
Cr-Commit-Position: refs/heads/master@{#333094}

Powered by Google App Engine
This is Rietveld 408576698